Changelog automation: apply proper top-level categorization precedence to meta PRs #50208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +587 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
|
I ran the test against 15.7 and had quite a few PRs that didn't have a subsection in Enhancements and Bug Fixes. Some landed still in the "Various" section. Enhancements.
Bugfixes
Various
I since then manually categorized them when I published Gutenberg 15.7 Release candidate 1 I might have also caused some of them, when I adjusted the labels prior to RC 1 |
priethor
changed the title
|
Thanks for checking, Birgit! This PR is not addressing PRs uncategorized or un-subcategorized, that's the scope for another PR 🙂 . The goal here is to avoid non-product PRs like Tooling or Code Quality from being in the main Enhancements or Bugfixes categories when there are conflicting labels. Great examples in your list are |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes the changelog automation generation to classify the meta/non-product PRs into the right top-level categories considering category precedence.
Please note that this will not solve uncategorized PRs.
Why?
The changelog generation doesn't apply the right category precedence when there is more than one top-level label, like a
[Type] Build Toolinglabel and[Type] Bug. Currently, a PR with both labels would be classified as a bugfix, but non-product and meta labels should always have precedence: fixing a tooling bug is not a bugfix in the product.How?
Testing Instructions
Run
npm run other:changelog -- --milestone="Gutenberg 15.6"