Base Styles: Add the editor input reset with increased specificity #49831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Enhancement
Mamaduka
commented
Apr 14, 2023
| border: $border-width solid $gray-900 !important; | ||
| box-shadow: none !important; | ||
| border-radius: $radius-block-ui !important; | ||
| box-sizing: border-box; |
There was a problem hiding this comment.
This is a minor bug fix to contain the HTML block inside the content box.
|
Size Change: +75 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Apr 17, 2023
packages/base-styles/_mixins.scss
Outdated
| box-shadow: none !important; | ||
| border-radius: $radius-block-ui !important; | ||
|
|
||
| /* Fonts smaller than 16px causes mobile safari to zoom. */ |
There was a problem hiding this comment.
If I recall correctly, /* */ in the SCSS compiler is kept in place, whereas // is stripped out. I think we may have used this in the past for anyone reviewing the CSS files, not just the SCSS files. But in part, I think "View source" is increasingly not something people do, and in part I also think there's some minification that happens with mixins making all context lost here. So it might be good to change this to the // syntax.
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is a follow-up to #49723.
PR adds a new mixin for resetting input fields to editor styles with increased specificity to avoid theme styles bleeding in.
I'm open to suggestions for a better mixin name.
Testing Instructions
Confirm that the Shortcode and Custom HTML blocks look as before.
Screenshots or screencast