-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fixed block toolbar positioning #49990
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -250,35 +260,7 @@ | |||
// except for the inserter on the left | |||
@include break-medium() { | |||
&.is-fixed { | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So much red. Glorious.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was so painful to write I almost felt sorry ahahhaha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For what it's worth, this behavior feels pretty solid now, and knowing the mixin has been used for the main editor window for years now should also boost confidence here, IMO. In fact, I hope to mock up a version of this for mobile next week :)
Co-authored-by: Joen A. <[email protected]>
Size Change: -22 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Flaky tests detected in 373d49d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4765988912
|
What?
Fixes #49988
Why?
Using the chimeric
.auto-fold
class to target states of the WP admin was wrong since starting at large viewports does not contain this class, hence breaking expectations.How?
Using the
editor-left
mixin to calculate the left position which takes into account all states of WP admin (full screen, not full screen, expanded sidebar etc).Testing Instructions
Testing Instructions for Keyboard
N/A
Screenshots or screencast