Block Editor: Prevent block styles from leaking into an inner Warning component
#40847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DAreRodz
commented
May 5, 2022
| @@ -3,6 +3,7 @@ | |||
| display: flex; | |||
| flex-wrap: wrap; | |||
| font-family: $default-font; | |||
| font-size: $default-font-size; | |||
There was a problem hiding this comment.
We need to specify a fixed font-size here as the padding property for this class is relative to the font size.
DAreRodz
commented
May 5, 2022
| @@ -14,6 +15,10 @@ | |||
| line-height: $default-line-height; | |||
| font-family: $default-font; | |||
| font-size: $default-font-size; | |||
| text-transform: none; | |||
There was a problem hiding this comment.
Avoids changes in "Typography > Letter case".
DAreRodz
commented
May 5, 2022
| @@ -14,6 +15,10 @@ | |||
| line-height: $default-line-height; | |||
| font-family: $default-font; | |||
| font-size: $default-font-size; | |||
| text-transform: none; | |||
| letter-spacing: normal; | |||
There was a problem hiding this comment.
Avoids changes in "Typography > Letter spacing".
DAreRodz
commented
May 5, 2022
Comment on lines
+20
to
+21
| font-weight: normal; | ||
| font-style: normal; |
There was a problem hiding this comment.
Avoids changes in "Typography > Appearance".
|
Size Change: +50 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
DAreRodz
added
[Package] Block editor
DAreRodz
changed the title
Warning component
DAreRodz
requested review from
ockham,
luisherranz,
michalczaplinski,
cbravobernal and
SantosGuillamot
|
This approach will require more updates when adding new block supports to Gutenberg. Maybe using a Shadow DOM could make sense here to isolate the styles? I know using Shadow DOM in React requires using imperative DOM APIs, but maybe it is worth trying? |
That's a good point. I ll try this approach in another PR. I think it makes to use the encapsulation that shadow DOM provides but we should also see how difficult that is. I don't want to create a whole new library for interfacing with WC just to solve a single problem 🙂 |
Just in case: you don't need to use WC (custom elements) to use the shadow DOM. You can attach it to a |
Oh, interesting! I did not know about this, thanks! :) |
|
Closing in favor of #40868 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
When a block uses the
Warningcomponent, some block styles can leak into that component and change how it looks. This PR prevents that.Why?
It is a weird UX. Fixes #40536
How?
See comments after this description.
Testing Instructions
Just follow the same steps as in the video posted in #40536 description and check that no color or typography option affects the warning message styles.
Screenshots or screencast