Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Editor: Prevent block styles from leaking into an inner Warning component #40847

Closed
wants to merge 1 commit into from
Closed

Block Editor: Prevent block styles from leaking into an inner Warning component #40847

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/block-editor/src/components/warning/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
display: flex;
flex-wrap: wrap;
font-family: $default-font;
font-size: $default-font-size;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to specify a fixed font-size here as the padding property for this class is relative to the font size.

padding: 1em;

// Block UI appearance.
Expand All @@ -14,6 +15,10 @@
line-height: $default-line-height;
font-family: $default-font;
font-size: $default-font-size;
text-transform: none;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoids changes in "Typography > Letter case".

letter-spacing: normal;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoids changes in "Typography > Letter spacing".

font-weight: normal;
font-style: normal;
Comment on lines +20 to +21
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoids changes in "Typography > Appearance".

color: $gray-900;
margin: 0;
}
Expand Down