Fix external styles leaking into Warning component #40868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +2.81 kB (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
michalczaplinski
changed the title
|
Awesome, thanks a lot @michalczaplinski! |
1 task
ockham
added
Backport to WP 6.7 Beta/RC
adamziel
pushed a commit
that referenced
this pull request
May 16, 2022
* Add gutenberg-warning custom element * Add only a wrapping div with all: initial * Update jest snapshot * Update the test case
|
I just cherry-picked this PR to the wp/6.0 branch to get it included in the next release: 7df643f |
adamziel
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix #40536
Why?
External styles have been leaking into the
<Warning />component.How?
Using the the
all: initialanddisplay: content. Some of the previous approaches are summarized in #40536 (comment)Initially, I've tried to use the Shadow DOM to fix this as suggested in #40847 (comment)
I've have since realised that the Shadow DOM prevents the styles inside of it from leaking to the outside but we needed the opposite - the component NOT to be affected by the outside styles.
The key to figuring out this problem was realizing that certain CSS properties are inheritable and that they are the ones that are "leaking" into the
<Warning/>component and messing up the styling. The Shadow DOM does not prevent those properties from being inherited. In order to prevent this, we needall: initial(as also mentioned in the linked article).I've also considered marking only the inheritable properties with
initialbut it's not necessary. This is because the "wrapping" div gets all of its styles reset toinitalbut its descendants are only influenced by the inheritable styles:Caveats
There are two (related) caveats with this approach that I'm not 100% happy with but I guess we can live with them:
Styles in our reset.css are NOT going to be applied to the
<Warning/>.User Agent styles are NOT going to be applied either.
I have noticed that there is a tiny discrepancy in how the warnings render pre- and post- this PR. I think this is because some padding is defined in
emand settingall: initialresets thefont-sizewhich is what controls the "unit" of theem:2022-05-09_19-37-08.mp4
Screenshots or screencast
(This is outdated because it was made when the PR was not finished):
https://www.loom.com/share/2b82de57b1b44ba9a21ebc84150642b1