Revert "Move Playwright snapshots into the same local folder (#40336)" #40412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1fc751c.
oandregal
added
[Type] Bug
|
I noticed the same thing... |
aristath
approved these changes
Apr 18, 2022
|
Size Change: 0 B Total Size: 1.23 MB ℹ️ View Unchanged
|
|
Shared in core-editor for visibility as well: slack link. |
|
I see the e2e failure affecting to other PRs as well. In lieu of a better fix, I'm going to merge this revert as to not be blocked. |
kevin940726
added a commit
that referenced
this pull request
Apr 18, 2022
kevin940726
added a commit
that referenced
this pull request
Apr 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This reverts #40336
Why?
Since it landed in
trunkall commits have been reported the same e2e test failure as well as PRs based ontrunk.How?
I don't know how the changes at #40336 are related to the e2e test, so I'm creating this PR to understand whether reverting helps.
Testing Instructions
Verify that e2e tests pass.