-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Playwright snapshots into the same local folder #40336
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
the
[Type] Bug
An existing feature does not function as intended
label
Apr 14, 2022
Size Change: 0 B Total Size: 1.23 MB ℹ️ View Unchanged
|
carolinan
approved these changes
Apr 14, 2022
aristath
approved these changes
Apr 18, 2022
oandregal
added a commit
that referenced
this pull request
Apr 18, 2022
This reverts commit 1fc751c.
oandregal
added a commit
that referenced
this pull request
Apr 18, 2022
kevin940726
added a commit
that referenced
this pull request
Apr 18, 2022
kevin940726
added a commit
that referenced
this pull request
Apr 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Move snapshot files in Playwright to a local
__snapshots__
folder, mimicking Jest's behavior.For instance, the below file name will be moved to:
This PR also removes an unnecessary snapshot file.
Why?
This solves #40291. Snapshot file names will no longer be that long so that older Git clients on Windows can correctly handle them.
How?
By customizing
testInfo.snapshotDir
to__snapshots__
in an automatic fixture.Testing Instructions
Older git clients should still work on the project. (I don't have the environment though so probably @carolinan could help test it? 🙇♂️)