Mobile - Notice list - Code improvements and bug fixes #40415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removes the shouldStack prop which is not used - Stack all notices in the same position if there's more than one - Refactor List component to functional component - Fixes bug where the notices weren't getting removed - Replace dimension listener with windowDimensions hook
geriux
added
[Status] In Progress
|
Size Change: 0 B Total Size: 1.23 MB ℹ️ View Unchanged
|
SiobhyB
approved these changes
Apr 19, 2022
There was a problem hiding this comment.
I tested both iOS and Android with this branch checked out, and was no longer able to replicate any of the duplication with the notice. This PR was also a nice masterclass for me in best practices and code quality (thank you!) :)
The issue with the notice was also noticeable when tapping the "Set/Removed Featured" button in an image block's settings multiple times in a row, which always bugged me. I'm happy to see it's fixed as part of these changes, too. 🎉
LGTM! Thanks Gerardo.
Aside: I believe the E2E test failure will be fixed when updating from trunk following the changes in #40412
Yay! Thank you for the review and testing!
Ohh glad that's fixed as well 🙌
Cool! I'll update it and merge 🚀 |
geriux
removed
the
Mobile App - Automation
SiobhyB
pushed a commit
that referenced
this pull request
Apr 26, 2022
- Removes the shouldStack prop which is not used - Stack all notices in the same position if there's more than one - Refactor List component to functional component - Fixes bug where the notices weren't getting removed - Replace dimension listener with windowDimensions hook
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gutenberg Mobile PR-> Mobile - Notice list - Code improvements and bug fixes wordpress-mobile/gutenberg-mobile#4768Fixes wordpress-mobile/WordPress-iOS#18036
Fixes wordpress-mobile/WordPress-Android#15643
What?
A few issues were opened reporting that toggling between the HTML / Visual mode of the editor does not track the change in the notices.
Why?
By checking the code I found the notices weren't getting removed from the store as well as the animation when collapsing wasn't running as expected.
How?
For the Notice component, it refactors the code with the following:
useWindowDimensions.onNoticeHiddenwhen it should, to remove the displayed notice from the store.For the NoticeList component:
shouldStackprop since it's not used at all.keyprop from the containersView.Testing Instructions
Test case 1 - Toggling between HTML/Visual mode
Test case 2 - Block actions
Screenshots or screencast