Fix failing tests and compatibility with 5.9. #36368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit fdf7185.
talldan
added
the
[Type] Automated Testing
talldan
commented
Nov 10, 2021
| // Wait for media modal to appear and upload image. | ||
| await page.waitForSelector( '.media-modal input[type=file]' ); | ||
| const inputElement = await page.$( '.media-modal input[type=file]' ); | ||
| const inputElement = await page.waitForSelector( |
There was a problem hiding this comment.
I couldn't tell why this test was failing. The image upload just wasn't happening, but it works when testing manually. I've modified it to upload the image in a different way, using the image block placeholder's Upload button. This is actually more succinct, though reduces test coverage for the media modal.
It could be related to this core bug or other changes to the media modal - https://core.trac.wordpress.org/ticket/54411
There was a problem hiding this comment.
Though it might actually be better to have test coverage for the placeholder upload button, given there are other tests for using the media modal. I think it's worth keeping this change.
|
Size Change: +4 B (0%) Total Size: 1.09 MB
ℹ️ View Unchanged
|
talldan
added
the
Backport to WP 6.7 Beta/RC
|
A lot of tests are failing because the Menus REST API hasn't been updated to use This was resulting in a 404 error that basically seems to have caused every site editor test to fail. This will need to be backported to core so that core isn't using the Possibly the same for navigation areas eventually too when https://core.trac.wordpress.org/ticket/54393 is patched. |
talldan
force-pushed
the
fix/tests-for-5.9
branch
from
83a8a55 to
5299541
Compare
talldan
force-pushed
the
fix/tests-for-5.9
branch
from
5299541 to
d9ded0b
Compare
|
All the remaining e2e test failures are like the other image upload failure mentioned here - #36368 (comment) Still unsure why they would be failing 🤔 |
|
Ok, have gotten to the bottom of this with some help. It seems the change in https://core.trac.wordpress.org/changeset/52059 is causing an issue with our e2e tests that interact with the media modal. Our tests usually use a hidden I've pushed a hopeful fix, but if it doesn't work I'd suggest skipping those tests until the issue in core is resolved (https://core.trac.wordpress.org/ticket/54411). |
talldan
requested review from
adamziel,
ajitbohra,
draganescu,
getdave,
kevin940726,
nerrad,
ntwb,
spacedmonkey,
tellthemachines and
TimothyBJacobs
as code owners
talldan
changed the title
Mamaduka
approved these changes
Nov 10, 2021
|
Thank you so much @talldan! |
This was referenced Nov 11, 2021
noisysocks
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently a draft PR, it reverts #36333. I'll push fixes here that are required for getting tests passing against WordPress 5.9.
A summary of the changes: