Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing tests and compatibility with 5.9. #36368

Merged
merged 6 commits into from
Nov 10, 2021
Merged

Fix failing tests and compatibility with 5.9. #36368

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c100966
Revert "Fix .wp-env.json to WP 5.8.1 (#36333)"
talldan Nov 10, 2021
fe1b696
Remove tests for menus endpoints, which now exist in WordPress core
talldan Nov 10, 2021
e869ec4
Fix image size test
talldan Nov 10, 2021
98a7f52
Change theme json test back to version in trunk
talldan Nov 10, 2021
d9ded0b
Update menu rest endpoints to stable
talldan Nov 10, 2021
e04c091
Fix media upload tests
talldan Nov 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .wp-env.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"core": "WordPress/WordPress#5.8.1",
"core": "WordPress/WordPress",
"plugins": [ "." ],
"themes": [ "WordPress/theme-experiments/tt1-blocks#[email protected]" ],
"env": {
Expand Down
4 changes: 0 additions & 4 deletions phpunit/class-block-fixture-test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,6 @@ class Block_Fixture_Test extends WP_UnitTestCase {
* @dataProvider data_block_fixtures
*/
function test_kses_doesnt_change_fixtures( $block, $filename ) {
// Skip this test while Gutenberg is pinned to WordPress 5.8.1.
// Once WordPress 5.9 is released, this test can be re-enabled.
// See: https://github.com/WordPress/gutenberg/pull/35611.
$this->markTestSkipped( 'This test requires WordPress 5.9. See: https://core.trac.wordpress.org/ticket/54261' );

// KSES doesn't allow data: URLs, so we need to replace any of them in fixtures.
$block = preg_replace( "/src=['\"]data:[^'\"]+['\"]/", 'src="https://wordpress.org/foo.jpg"', $block );
Expand Down
Loading