Fix .wp-env.json to WP 5.8.1 #36333
Merged
Fix .wp-env.json to WP 5.8.1 #36333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisysocks
added
[Type] Build Tooling
|
Since pinning to other commits didn't appear to work, I've tried pinning this to WordPress 5.8.1 and skipping the test introduced in #35611. This leaves one remaining failing test, |
Try fixing .wp-env.json to the 5.8 branch as a temporary fix for Gutenberg CI. This should unblock Gutenberg developers while the plugin is made compatible with WordPress trunk.
… core WP_Theme_JSON_Resolver class
andrewserong
force-pushed
the
try/fix-wp-env-to-5.8
branch
from
995e595 to
5a8a001
Compare
andrewserong
approved these changes
Nov 10, 2021
andrewserong
added a commit
that referenced
this pull request
Nov 10, 2021
* Fix .wp-env.json to WP 5.8 Try fixing .wp-env.json to the 5.8 branch as a temporary fix for Gutenberg CI. This should unblock Gutenberg developers while the plugin is made compatible with WordPress trunk. * Pin to 5.8.1 to fix majority of unit test failures * Pin to specific sha that fixed php unit tests * Try a different sha * Try pinning to 5.8.1 and skipping failing test that requires 5.9 * Fix linting issue * Update merges child theme JSON test to use Gutenberg class instead of core WP_Theme_JSON_Resolver class Co-authored-by: Glen Davies <[email protected]> Co-authored-by: Andrew Serong <[email protected]>
|
Cherry picked into the Gutenberg 11.9 release in: 00b7a54 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try fixing .wp-env.json to the 5.8.1 branch as a temporary fix for Gutenberg CI. This should unblock Gutenberg developers while the plugin is made compatible with WordPress trunk.
Other changes include:
test_kses_doesnt_change_fixturestests introduced in Tests: Run block fixtures through KSES. #35611. These tests depend on a change in WordPress 5.9 (https://core.trac.wordpress.org/ticket/54261), so in order to get the tests passing in 5.8.1, for the moment these tests are marked as skipped.test_merges_child_theme_json_into_parent_theme_jsontest for the theme resolver was pointing to the coreWP_Theme_JSON_Resolverclass instead of the Gutenberg oneWP_Theme_JSON_Resolver_Gutenberg. This PR updates the test to use the latter so we're targeting the Gutenberg class.