Fix crash from non-adjustable unit RangeCell a11y activation #30636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the unit picker callback was always invoked when a11y tools activated the element. This caused the app to crash whenever the element did not have adjustable units.
dcalhoun
added
the
Mobile App - i.e. Android or iOS
|
Size Change: 0 B Total Size: 1.42 MB ℹ️ View Unchanged
|
Merged
2 tasks
guarani
approved these changes
Apr 8, 2021
There was a problem hiding this comment.
The fix itself looks great and I tested on iOS and Android and the crash doesn't happen anymore. I tested sliders that don't have a changeable unit, too.
I had a few issues with changing the slider value on iOS, but they don't seem related at all to this PR. For completeness, they were:
- I couldn't adjust the slider value using VoiceOver. I tried two techniques:
- Single tap approach: Single tap to select the slider, drag up and down (or left and right) to adjust value: This didn't work, as I dragged different elements would become selected.
- Double tap approach: Single tap to select the slider, double tap and hold, hear the three rising tones, and swipe with one finger right or left (up and down), but the slider doesn't move.
- I could change the slider value on Android using TalkBack, but noticed one oddity:
- On a Column block, I changed the unit to px (which removes the slider), now tapping on the column area flickers the TalkBack focus but it doesn't remain on the column area (double-tapping still allows me to change the units if I like)
|
Tested as well and everything works as expected. 👍 Thanks for taking care of this so fast @dcalhoun ! PXL_20210409_003731824.mp4 |
guarani
pushed a commit
that referenced
this pull request
Apr 9, 2021
* Avoid invoking possible null callback Previously, the unit picker callback was always invoked when a11y tools activated the element. This caused the app to crash whenever the element did not have adjustable units. * Add test coverage for RangeCell accessibility actions
This was referenced Apr 9, 2021
guarani
added a commit
that referenced
this pull request
Apr 10, 2021
* Release script: Update react-native-editor version to 1.50.0 * Release script: Update with changes from 'npm run core preios' * Gutenberg Plugin: Remove deprecations planned for 10.3 release (#30417) * Gutenberg Plugin: Remove deprecations planned for 10.3 release * Docs: Add changelog entry * Closed changelog for 1.50.0 * Release script: Update react-native-editor version to 1.50.1 * Release script: Update with changes from 'npm run core preios' * RNMobile: Truncate rangecell screenreader decimals (#30678) Screenreaders (VoiceOver and TalkBack) were reading values of range-cells with too much precision. For example, a Column block with three columns would read widths as 33.33333333 when it should be read as 33.3. * [RNMobile] react native bridge UBE path fix (#30650) * Fixed the asset path for the unsupported-block-editor * symlink update. * Use the default div tagName on native (#30645) Co-authored-by: Ceyhun Ozugur <[email protected]> * Fix crash from non-adjustable unit RangeCell a11y activation (#30636) * Avoid invoking possible null callback Previously, the unit picker callback was always invoked when a11y tools activated the element. This caused the app to crash whenever the element did not have adjustable units. * Add test coverage for RangeCell accessibility actions * Re-added symlink update. * Update changelog for react-native-editor Co-authored-by: Greg Ziółkowski <[email protected]> Co-authored-by: Joel Dean <[email protected]> Co-authored-by: Ceyhun Ozugur <[email protected]> Co-authored-by: David Calhoun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #30625. Previously, the unit picker callback was always invoked when a11y tools activated the element. This caused the app to crash whenever the element did not have adjustable units.
How has this been tested?
Following the reproduction steps outlined within #30625.
Additionally...
Expected: The app does not crash. The editor opens the unit picker.
Screenshots
n/a
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).