Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash from non-adjustable unit RangeCell a11y activation #3350

Merged
merged 3 commits into from
Apr 8, 2021
Merged

Fix crash from non-adjustable unit RangeCell a11y activation #3350

merged 3 commits into from
Apr 8, 2021

Conversation

dcalhoun
Copy link
Member

@dcalhoun dcalhoun commented Apr 8, 2021

Fixes WordPress/gutenberg#30625.

To test: follow steps outlined in WordPress/gutenberg#30636.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@dcalhoun dcalhoun mentioned this pull request Apr 8, 2021
Merged
7 tasks
@guarani guarani self-requested a review April 8, 2021 23:25
@peril-wordpress-mobile
Copy link

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

guarani
guarani approved these changes Apr 8, 2021
View reviewed changes
Copy link
Contributor

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, I added a release note (for internal use, since we won't be including it in the main apps release notes) and updated the commit to the merge commit on Gutenberg.

@guarani guarani enabled auto-merge April 8, 2021 23:33
@guarani guarani added this to the 1.51.1 milestone Apr 8, 2021
@guarani guarani merged commit 82e1b42 into develop Apr 8, 2021
@guarani guarani deleted the fix/crash-from-rangecell-voiceover-activation branch April 8, 2021 23:55
@guarani guarani added this to the 1.50.1 (17.1) milestone Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guarani guarani guarani approved these changes

Assignees
No one assigned
Labels
Accessibility bugfix [Type] Crash
Projects
None yet
Milestone
1.50.1 (17.1)
Development

Successfully merging this pull request may close these issues.

Mobile: The app crashes on slider container selection in VoiceOver/TalkBack accessibility mode
2 participants
@dcalhoun @guarani