RNMobile: Use the default div tagName on native for the Quote block #30645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guarani
added
the
Mobile App - i.e. Android or iOS
guarani
changed the title
|
Size Change: +19 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
Merged
2 tasks
jd-alexander
approved these changes
Apr 9, 2021
There was a problem hiding this comment.
Thanks for these changes @guarani I verified that the Quote block works as expected on Android and iOS. Doing the split resulted in the text going on a newline and the contents of HTML mode were as expected with no irregular cite or p tags. LGTM 🚢
guarani
added a commit
that referenced
this pull request
Apr 9, 2021
Co-authored-by: Ceyhun Ozugur <[email protected]>
guarani
added a commit
that referenced
this pull request
Apr 10, 2021
* Release script: Update react-native-editor version to 1.50.0 * Release script: Update with changes from 'npm run core preios' * Gutenberg Plugin: Remove deprecations planned for 10.3 release (#30417) * Gutenberg Plugin: Remove deprecations planned for 10.3 release * Docs: Add changelog entry * Closed changelog for 1.50.0 * Release script: Update react-native-editor version to 1.50.1 * Release script: Update with changes from 'npm run core preios' * RNMobile: Truncate rangecell screenreader decimals (#30678) Screenreaders (VoiceOver and TalkBack) were reading values of range-cells with too much precision. For example, a Column block with three columns would read widths as 33.33333333 when it should be read as 33.3. * [RNMobile] react native bridge UBE path fix (#30650) * Fixed the asset path for the unsupported-block-editor * symlink update. * Use the default div tagName on native (#30645) Co-authored-by: Ceyhun Ozugur <[email protected]> * Fix crash from non-adjustable unit RangeCell a11y activation (#30636) * Avoid invoking possible null callback Previously, the unit picker callback was always invoked when a11y tools activated the element. This caused the app to crash whenever the element did not have adjustable units. * Add test coverage for RangeCell accessibility actions * Re-added symlink update. * Update changelog for react-native-editor Co-authored-by: Greg Ziółkowski <[email protected]> Co-authored-by: Joel Dean <[email protected]> Co-authored-by: Ceyhun Ozugur <[email protected]> Co-authored-by: David Calhoun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #30548
See wordpress-mobile/gutenberg-mobile#3352
This PR prevents the
tagNameprop from being passed to the Quote block citation on mobile. While it was added in #30190 for both web and mobile, it resulted in a regression.Not passing in the
tagNameappears to be the best solution we have at hand, although it isn't ideal since thetagNameshould correspond to the tag that the rich text represents i.e. a<cite>tag here.How has this been tested?
Types of changes
Bug fix.
Checklist:
*.native.jsfiles for terms that need renaming or removal).