Fix navigation editor error #28190
Merged
Fix navigation editor error #28190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h selectionStart and selectionEnd props
talldan
added
[Type] Regression
talldan
requested review from
ajitbohra,
draganescu,
kevin940726,
nerrad,
noisysocks,
ntwb and
tellthemachines
as code owners
|
Size Change: +1.64 kB (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
talldan
commented
Jan 14, 2021
| matchUrlToRoute( request.url(), matchingRoutes ) && | ||
| request.method() === restMethod, | ||
| onRequestMatch: createJSONResponse( | ||
| processor( responsesByMethod[ restMethod ] ) |
There was a problem hiding this comment.
While the test is mostly working, this processor shouldn't run for every method, a POST to create a menu only returns a single item so doesn't need to be mapped.
There was a problem hiding this comment.
Probably best to get rid of this concept and process the data before it's passed into the mocking function.
draganescu
approved these changes
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently when interacting with blocks on the navigation screen there's an error in the console:
entity-provider.js:175 Uncaught (in promise) TypeError: Cannot read property 'selectionStart' of undefinedThis seems to have been introduced by #27954, one of the changes there is that the
onChangefunction returned by theuseEntityBlockEditorhook must be passed an object as the second argument with the selectionStart and selection End.The navigation editor wraps
onChangeand wasn't passing this new second argument, but does now after this fix.How has this been tested?
Added an e2e test
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: