-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate block editor initializations #27954
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Code Quality
Issues or PRs that relate to code quality
label
Jan 1, 2021
Size Change: -381 B (0%) Total Size: 1.3 MB
ℹ️ View Unchanged
|
youknowriad
force-pushed
the
update/consolidate-editor-intialization
branch
from
January 1, 2021 13:12
c340c3a
to
0ef0331
Compare
youknowriad
force-pushed
the
update/consolidate-editor-intialization
branch
from
January 5, 2021 09:03
0ef0331
to
0688fcc
Compare
youknowriad
force-pushed
the
update/consolidate-editor-intialization
branch
from
January 11, 2021 14:21
a7e4528
to
484248b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All block editors that rely on entities use
useEntityBlockEditor
to initialize the block editor aside the "post" editor which had its own custom hook. This PR consolidates that.I'm not sure if there's any specific requirements for that context but I guess the e2e tests will confirm that.