Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix navigation editor error #28190

Merged
merged 5 commits into from
Jan 18, 2021
Merged

Fix navigation editor error #28190

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
97718f2
Fix error with useNavigationBlockEditor, onChange expects options wit…
talldan Jan 14, 2021
4cba74b
Add navigation editor test for creating a menu
talldan Jan 14, 2021
fbf0ad0
Update test to make endpoint mocking realistic
talldan Jan 15, 2021
9f77e28
Update comment
talldan Jan 15, 2021
cbb119b
Wait for block to be added
talldan Jan 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Wait for block to be added
  • Loading branch information
@talldan
talldan committed Jan 18, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
commit cbb119b19977766d37e0cabcb824baf31804329c
1 change: 1 addition & 0 deletions packages/e2e-tests/specs/experiments/navigation-editor.test.js
View file
Original file line number Diff line number Diff line change
@@ -189,6 +189,7 @@ describe( 'Navigation editor', () => {
await page.keyboard.press( 'Escape' );

// Select the navigation block and create a block from existing pages.
await page.waitForSelector( 'div[aria-label="Block: Navigation"]' );
await page.click( 'div[aria-label="Block: Navigation"]' );

const [ addAllPagesButton ] = await page.$x(