Upgrade Reakit to version 1.3.4 #28013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +4.07 kB (0%) Total Size: 1.3 MB
ℹ️ View Unchanged
|
diegohaz
changed the title
diegohaz
requested review from
adamziel,
ajitbohra,
chrisvanpatten,
draganescu,
ellatrix,
kevin940726,
noisysocks,
talldan and
tellthemachines
as code owners
|
Thanks @diegohaz 👍🏻 I raised that in the past, it looks like we should look into how we could stop duplicating bundled code from Reakit: We could add shared APIs to gutenberg/packages/a11y/src/index.js Line 40 in 61f57f4 Any thoughts? |
@gziolo I don't really know how to interpret that table. I expect that when we use both |
|
The issue exists inside the WordPress core/Gutenberg plugin. It won't be an issue for JS apps that use one entry point and code splitting. We have a long list of entry points. They are externalized between each of them and referenced through |
|
That makes sense! Why do you think that line ( |
It might be my personal resistance to side effects in packages. Maybe we could lazy execute it when |
|
@youknowriad, is #28013 (comment) something we should plan for WordPress 5.7 or you think we can delay further? |
|
Do you think the solution here could be to use components from "Components" that rely on reakit instead of using reakit directly in the other packages? |
|
Yes, that would work as well since |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades Reakit to version 1.3.4.
The most relevant feature is that composite items are now automatically sorted when their position change in the DOM, so we don't need to call
unstable_sort()manually anymore.Changelog since v1.1.0
1.3.4 (2021-01-06)
Bug Fixes
CompositeItemtabIndex fix (#821) (1390d31)1.3.3 (2021-01-03)
Bug Fixes
CompositeItemwithtabindex=0on the first render (#817) (3d81514)1.3.2 (2020-12-11)
Bug Fixes
stateprop (#799) (a21bb2b), closes #798Menuscroll jump (#801) (96f5dd5), closes #7511.3.1 (2020-11-26)
Bug Fixes
Dialog(#793) (d9a49ef)1.3.0 (2020-11-12)
Features
Rolecomponent (#728) (5fa51a7)shiftoption touseCompositeState(#727) (7861395)Comboboxcomponent (#688) (ad7063b)includesBaseElementoption touseCompositeState(#726) (cf3ba56)onChangewhen settingCompositeItemWidgetvalue (0b5b3cb)1.2.6 (2020-11-12)
Bug Fixes
unstable_virtualoption on mobile devices (#783) (ecdc4ef)Composite(#784) (9bcbfe6)1.2.5 (2020-09-22)
Bug Fixes
Compositeinfinite loop on Firefox (#748) (4a1c644), closes #747disabledprop being passed to elements that don't support it (#725) (d982a61), closes #722asprop (#736) (c594166)1.2.4 (2020-09-03)
Bug Fixes
1.2.3 (2020-08-24)
Bug Fixes
1.2.2 (2020-08-17)
Bug Fixes
focusmethod exists on the dialog disclosure element (#710) (85dd073)Compositefor React 17 (#711) (0ad76e6)unstable_virtualistrueon React 17 (#715) (81ec3a3)focus/blurevent order inComposite(#713) (891976b)1.2.1 (2020-08-13)
Bug Fixes
RadioGroups (#703) (212adbd), closes #7021.2.0 (2020-08-06)
Features
Gridcomponent (#685) (51e17fb)composite.sortmethod (#690) (1f66168)id.setBaseIdmethod (#691) (5c52c71)Menuinstead ofMenuItemon mouse click onMenuButton(#694) (d57b97f)1.1.2 (2020-07-18)
Bug Fixes
composite.unstable_sorton Firefox (f973f77)Dialogfocus loss (#682) (8ae0da7), closes #677MenuButtonnot receiving focus afterMenucloses (#692) (e649f20)1.1.1 (2020-06-21)
Bug Fixes
Compositereferences (9d9eff2), closes #667 (comment)