Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add stable id.setBaseId method #691

Merged
merged 1 commit into from
Jul 14, 2020
Merged

feat: Add stable id.setBaseId method #691

merged 1 commit into from
Jul 14, 2020

Conversation

diegohaz
Copy link
Member

This PR marks the id.unstable_setBaseId method as stable.

Does this PR introduce a breaking change?

No. But people relying on the unstable feature will have to update their code.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 101b98d:

Sandbox Source
Reakit Configuration

@ariakit-bot
Copy link

Deploy preview for reakit ready!

Built with commit 101b98d

https://deploy-preview-691--reakit.netlify.app

@github-actions
Copy link
Contributor

Size Change: -4 B (0%)

Total Size: 251 kB

Filename Size Change
packages/reakit/dist/reakit.min.js 31.7 kB -4 B (0%)
ℹ️ View Unchanged
Filename Size Change
packages/reakit-playground/dist/reakit-playground.min.js 186 kB 0 B
packages/reakit-system-bootstrap/dist/reakit-system-bootstrap.min.js 19.2 kB 0 B
packages/reakit-system-palette/dist/reakit-system-palette.min.js 8.84 kB 0 B
packages/reakit-system/dist/reakit-system.min.js 2.21 kB 0 B
packages/reakit-utils/dist/reakit-utils.min.js 3.11 kB 0 B

compressed-size-action

@codecov
Copy link

codecov bot commented Jul 14, 2020

Codecov Report

Merging #691 into next will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             next     #691   +/-   ##
=======================================
  Coverage   95.49%   95.49%           
=======================================
  Files         176      176           
  Lines        2821     2821           
  Branches      722      722           
=======================================
  Hits         2694     2694           
  Misses        127      127           
Impacted Files Coverage Δ
packages/reakit/src/Composite/__keys.ts 100.00% <ø> (ø)
packages/reakit/src/Dialog/__keys.ts 100.00% <ø> (ø)
packages/reakit/src/Disclosure/__keys.ts 100.00% <ø> (ø)
packages/reakit/src/Form/__keys.ts 100.00% <ø> (ø)
packages/reakit/src/Grid/__keys.ts 100.00% <ø> (ø)
packages/reakit/src/Id/IdState.ts 100.00% <ø> (ø)
packages/reakit/src/Menu/__keys.ts 100.00% <ø> (ø)
packages/reakit/src/Popover/__keys.ts 100.00% <ø> (ø)
packages/reakit/src/Radio/__keys.ts 100.00% <ø> (ø)
packages/reakit/src/Rover/__keys.ts 100.00% <ø> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d96bc0...101b98d. Read the comment docs.

@diegohaz diegohaz merged commit 5c52c71 into next Jul 14, 2020
@diegohaz diegohaz deleted the feat/id-set-base-id branch July 14, 2020 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants