fix: Stop warning when using invalid composite roles on Composite
#784
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the warning that
Composite
shows when the developer doesn't pass any role prop or pass an invalid composite role prop to theComposite
component.The reason is that there are valid use cases for omitting the role prop. For example, we could create multiple connected listbox elements to implement the ARIA 1.2 listbox group pattern for screen readers that still don't support it, like VoiceOver. This use case is better explained on WordPress/gutenberg#24975 (comment).
With the Reakit Composite module, the implementation would be something like this, where the
listbox
role is not passed to theComposite
component.