-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport fixes to WordPress 5.5 beta2 #23903
Conversation
…n a console error (#23666)
…sted block list, but root appender is used. (#23668) * Remove use of getSelectionEnd to determine where blocks should be inserted * Add e2e tests
Image edit: Fix cases where the edited Image src doesn't match the attachment ID. Includes backwards compatibility for WordPress 5.4 or lower.
* Search: Fix attribute defaults Prior to d26842b, the Search block's label and buttonText attributes defaulted to `__( 'Search' )`. This meant that adding a Search block to a post or page resulted in `<!-- wp:search /-->` being inserted into the HTML. In d26842b, the defaults were removed so that Search could use a block.json file. The default values were instead implemented using a default block variation. This, however, meant that Search blocks added prior to d26842b would render with a blank label and button. This fix is to default label and buttonText to `__( 'Search' )` in the render_callback. Care must be taken here to permit these attributes to be '' in which case the label and/or button are hidden. * Try to trick GitHub into re-running tests
Co-authored-by: Zebulan Stanphill <[email protected]>
Co-authored-by: Riad Benguella <[email protected]>
Size Change: +267 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
What's the process for this? Do you remove the label afterwards? Anything more we should include? |
@ellatrix yes, that's the process, I explicitly left the patterns ones out for this beta. These require their own backport in Core, but better done once they are all ready. |
These are the fixes included in this PR: