Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set quick inserter content width to 100% on screens below 782px #23896

Merged

Conversation

javidalkaruzi
Copy link
Contributor

Description

This pull request addressed #23755. When the browser widow width reaches 782 pixels or less, the inserter moves to cover the entire page however the content does not fill the entire width.

How has this been tested?

Observed on Ubuntu 20.04 with the following browsers

  • Chromium Version 83.0.4103.116 (Official Build) snap (64-bit)
  • Firefox 78.0.1 (64-bit)

Screenshots

Original
image

Fixed
image

Types of changes

Bug fix

@youknowriad youknowriad added [Type] Bug An existing feature does not function as intended Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta labels Jul 13, 2020
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 thanks for the fix.

@youknowriad youknowriad merged commit d697158 into WordPress:master Jul 13, 2020
@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jul 13, 2020
@github-actions
Copy link

Congratulations on your first merged pull request, @javidalkaruzi! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!

@github-actions github-actions bot added this to the Gutenberg 8.6 milestone Jul 13, 2020
youknowriad added a commit that referenced this pull request Jul 13, 2020
@youknowriad youknowriad removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Jul 13, 2020
@javidalkaruzi javidalkaruzi deleted the fix/quick-editor-size-below-782 branch August 10, 2020 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants