Image Editor: When editing, pass the edited image src. #23703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azaozz
requested review from
ajlende,
spacedmonkey and
TimothyBJacobs
as code owners
|
Corresponding trac ticket: https://core.trac.wordpress.org/ticket/50565. |
|
Size Change: +2 B (0%) Total Size: 1.14 MB
ℹ️ View Unchanged
|
TimothyBJacobs
approved these changes
Jul 6, 2020
There was a problem hiding this comment.
I think we can safely merge this now. The REST API doesn't error on unrecognized parameters, so if someone is running on Trunk + GB Trunk the parameter will be passed and just won't be operated on.
We'll need to wait to merge the patch in Core until the same time as the updated GB JS lands.
azaozz
added
the
[Priority] High
|
Needs to be added to trunk (ideally before 5.5-beta2) to unblock https://core.trac.wordpress.org/ticket/50565. Only the tiny js change matters for there :) |
youknowriad
added
the
Backport to WP 6.7 Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Jul 13, 2020
Image edit: Fix cases where the edited Image src doesn't match the attachment ID. Includes backwards compatibility for WordPress 5.4 or lower.
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
mcsf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23702.
Description
Adds the image
srcto the Save request when editing an image. On the API side the image meta (retrieved by using the attachment ID) is verified against the src.Checklist: