Template Switcher: Add theme preview #21768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +331 B (0%) Total Size: 842 kB
ℹ️ View Unchanged
|
ockham
requested review from
vindl,
noahtallen,
shaunandrews and
Addison-Stavlo
packages/edit-site/src/components/template-switcher/theme-preview.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
This works very well! And the code looks good from my point of view.
I wonder if we should be displaying all of these previews on focus for use in a tabbing flow. 🤔 - But I don't think that concern should hold up this PR as none of the others work that way yet either. Thoughts for future iterations!
Indeed, I was also wondering about a11y implications but decided to hold off for now because the pre-existing template previews are also on-hover only. But yeah, definitely material for future iterations. |
ockham
force-pushed
the
add/template-switcher-theme-preview
branch
from
14c131d to
66d8d28
Compare
|
Some tests currently failing. Waiting for #21780 which should fix them. |
ockham
force-pushed
the
add/template-switcher-theme-preview
branch
from
66d8d28 to
58b2810
Compare
53 tasks
vindl
approved these changes
Apr 22, 2020
6 tasks
ockham
added a commit
that referenced
this pull request
Jun 28, 2020
In #21578, I added a few fields to Core's `/themes` endpoint, for use by the Site Editor's Template Switcher (see both #21578 and #21768). I then submitted those changes as a [PR](WordPress/wordpress-develop#222) against Core. That PR underwent a number of modifications and was eventually merged; the new fields will be part of the `/themes` endpoint exposed by Core starting from the next WP release. This PR updates the fields added by Gutenberg to follow the same semantics, as well as the callsites that use that endpoint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add on-hover theme preview to site editor's template switcher (see mockups).
Fixes #20469.
How has this been tested?
Screenshots
Types of changes
Extends existing feature.
Checklist: