Fix e2e tests by removing unecessary assertions & properly installing deps in api-fetch package #21780

getdave · 2020-04-22T08:48:02Z

This fixes x2 problems that have broken e2e tests:

1. Unwanted deprecation notice assertions

Now that #21721 has landed the deprecation notice for useApiFetch within the Navigation Block no longer fires for that block (because it no longer uses the hook!).

Therefore we no longer need to add assertions in our e2e tests to expect the console to warning about this deprecation. This PR removes those assertions from the e2e tests.

gutenberg/packages/e2e-tests/specs/experiments/navigation.test.js

Lines 166 to 168 in 8acbb4f

    
           expect( console ).toHaveWarnedWith( 
        
           	'useApiFetch is deprecated and will be removed from Gutenberg in version 8.1.0. Please use apiFetch instead.' 
        
           );

and

gutenberg/packages/e2e-tests/specs/experiments/multi-entity-saving.test.js

Lines 176 to 178 in 8acbb4f

    
           expect( console ).toHaveWarnedWith( 
        
           	'useApiFetch is deprecated and will be removed from Gutenberg in version 8.1.0. Please use apiFetch instead.' 
        
           );

2. Incorrectly installed dependency of @wordpress/api-fetch

Previously the @wordpress/deprecated dependency was directly installed into @wordpress/api-fetch without using lerna. This has been corrected.

How has this been tested?

On Master branch

Run e2e test suite.
You should see failures relating to the useApiFetch deprecation notice above

 Expected mock function to be called with:
    ["useApiFetch is deprecated and will be removed from Gutenberg in version 8.1.0. Please use apiFetch instead."]
    but it was called with:
      174 | 				activeSaveSiteSelector
      175 | 			);
    > 176 | 			expect( console ).toHaveWarnedWith(
          | 			                  ^
      177 | 				'useApiFetch is deprecated and will be removed from Gutenberg in version 8.1.0. Please use apiFetch instead.'
      178 | 			);
      179 | 			expect( enabledButton ).not.toBeNull();

On this PR's branch

Run e2e test suite.
You should see no failures relating to the useApiFetch hook

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

My code is tested.
My code follows the WordPress code style.
My code follows the accessibility standards.
My code has proper inline documentation.
I've included developer documentation if appropriate.
I've updated all React Native files affected by any refactorings/renamings in this PR.

No idea why this one even had to be added in the first place.

github-actions · 2020-04-22T08:54:28Z

Size Change: 0 B

Total Size: 842 kB

ℹ️ View Unchanged

Filename	Size	Change
`build/a11y/index.js`	1.02 kB	0 B
`build/annotations/index.js`	3.62 kB	0 B
`build/api-fetch/index.js`	4.08 kB	0 B
`build/autop/index.js`	2.82 kB	0 B
`build/blob/index.js`	620 B	0 B
`build/block-directory/index.js`	6.24 kB	0 B
`build/block-directory/style-rtl.css`	760 B	0 B
`build/block-directory/style.css`	761 B	0 B
`build/block-editor/index.js`	105 kB	0 B
`build/block-editor/style-rtl.css`	10.2 kB	0 B
`build/block-editor/style.css`	10.2 kB	0 B
`build/block-library/editor-rtl.css`	7.1 kB	0 B
`build/block-library/editor.css`	7.1 kB	0 B
`build/block-library/index.js`	112 kB	0 B
`build/block-library/style-rtl.css`	7.17 kB	0 B
`build/block-library/style.css`	7.18 kB	0 B
`build/block-library/theme-rtl.css`	683 B	0 B
`build/block-library/theme.css`	685 B	0 B
`build/block-serialization-default-parser/index.js`	1.88 kB	0 B
`build/block-serialization-spec-parser/index.js`	3.1 kB	0 B
`build/blocks/index.js`	57.7 kB	0 B
`build/components/index.js`	198 kB	0 B
`build/components/style-rtl.css`	16.9 kB	0 B
`build/components/style.css`	16.9 kB	0 B
`build/compose/index.js`	6.66 kB	0 B
`build/core-data/index.js`	11.4 kB	0 B
`build/data-controls/index.js`	1.25 kB	0 B
`build/data/index.js`	8.43 kB	0 B
`build/date/index.js`	5.47 kB	0 B
`build/deprecated/index.js`	772 B	0 B
`build/dom-ready/index.js`	569 B	0 B
`build/dom/index.js`	3.1 kB	0 B
`build/edit-navigation/index.js`	3.54 kB	0 B
`build/edit-navigation/style-rtl.css`	485 B	0 B
`build/edit-navigation/style.css`	485 B	0 B
`build/edit-post/index.js`	27.9 kB	0 B
`build/edit-post/style-rtl.css`	12.3 kB	0 B
`build/edit-post/style.css`	12.3 kB	0 B
`build/edit-site/index.js`	10.5 kB	0 B
`build/edit-site/style-rtl.css`	5.04 kB	0 B
`build/edit-site/style.css`	5.04 kB	0 B
`build/edit-widgets/index.js`	7.5 kB	0 B
`build/edit-widgets/style-rtl.css`	4.67 kB	0 B
`build/edit-widgets/style.css`	4.66 kB	0 B
`build/editor/editor-styles-rtl.css`	428 B	0 B
`build/editor/editor-styles.css`	431 B	0 B
`build/editor/index.js`	43.3 kB	0 B
`build/editor/style-rtl.css`	3.28 kB	0 B
`build/editor/style.css`	3.27 kB	0 B
`build/element/index.js`	4.65 kB	0 B
`build/escape-html/index.js`	733 B	0 B
`build/format-library/index.js`	7.32 kB	0 B
`build/format-library/style-rtl.css`	502 B	0 B
`build/format-library/style.css`	502 B	0 B
`build/hooks/index.js`	2.13 kB	0 B
`build/html-entities/index.js`	622 B	0 B
`build/i18n/index.js`	3.56 kB	0 B
`build/is-shallow-equal/index.js`	711 B	0 B
`build/keyboard-shortcuts/index.js`	2.51 kB	0 B
`build/keycodes/index.js`	1.94 kB	0 B
`build/list-reusable-blocks/index.js`	3.12 kB	0 B
`build/list-reusable-blocks/style-rtl.css`	226 B	0 B
`build/list-reusable-blocks/style.css`	226 B	0 B
`build/media-utils/index.js`	5.29 kB	0 B
`build/notices/index.js`	1.79 kB	0 B
`build/nux/index.js`	3.4 kB	0 B
`build/nux/style-rtl.css`	616 B	0 B
`build/nux/style.css`	613 B	0 B
`build/plugins/index.js`	2.67 kB	0 B
`build/primitives/index.js`	1.49 kB	0 B
`build/priority-queue/index.js`	789 B	0 B
`build/redux-routine/index.js`	2.84 kB	0 B
`build/rich-text/index.js`	14.8 kB	0 B
`build/server-side-render/index.js`	2.67 kB	0 B
`build/shortcode/index.js`	1.7 kB	0 B
`build/token-list/index.js`	1.28 kB	0 B
`build/url/index.js`	4.02 kB	0 B
`build/viewport/index.js`	1.84 kB	0 B
`build/warning/index.js`	1.14 kB	0 B
`build/wordcount/index.js`	1.17 kB	0 B

_{compressed-size-action}

talldan

If the tests pass I see no reason not to merge 👍

Thanks for following up on this!

…kage As per packages/README.md

ockham · 2020-04-22T12:41:19Z

Thanks @Soean for updating the package-lock.json! That should fix the check-local-changes error 🤞

Remove unnecessary console expects

9e7275d

getdave added [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Block] Navigation Affects the Navigation Block labels Apr 22, 2020

getdave requested a review from aduth April 22, 2020 08:48

getdave self-assigned this Apr 22, 2020

Remove other expect statement

9ecdb43

No idea why this one even had to be added in the first place.

getdave marked this pull request as ready for review April 22, 2020 08:54

getdave requested review from ajitbohra, nerrad, ntwb and talldan as code owners April 22, 2020 08:54

talldan approved these changes Apr 22, 2020

View reviewed changes

talldan and others added 2 commits April 22, 2020 18:19

Try adding package lock changes

f9a3a12

Use lerna to properly install deprecated dependency for api-fetch pac…

d88eacf

…kage As per packages/README.md

getdave requested review from mmtr and youknowriad as code owners April 22, 2020 11:00

Update changelog

9697dad

getdave changed the title ~~Remove unnecessary useApiFetch console warning assertions in e2e tests~~ Fix e2e tests by removing unecessary assertions & properly installing deps in api-fetch package Apr 22, 2020

getdave mentioned this pull request Apr 22, 2020

Adds deprecation notice to useApiFetch hook #21723

Merged

6 tasks

Update package-lock

e3d0111

ockham mentioned this pull request Apr 22, 2020

Template Switcher: Add theme preview #21768

Merged

6 tasks

ockham merged commit f8e4c9c into master Apr 22, 2020

ockham deleted the fix/remove-expected-deprecation-warnings-in-e2e-tests branch April 22, 2020 12:57

github-actions bot added this to the Gutenberg 8.0 milestone Apr 22, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix e2e tests by removing unecessary assertions & properly installing deps in api-fetch package #21780

Fix e2e tests by removing unecessary assertions & properly installing deps in api-fetch package #21780

getdave commented Apr 22, 2020 •

edited

Loading

github-actions bot commented Apr 22, 2020 •

edited

Loading

talldan left a comment

ockham commented Apr 22, 2020

	expect( console ).toHaveWarnedWith(
	'useApiFetch is deprecated and will be removed from Gutenberg in version 8.1.0. Please use apiFetch instead.'
	);

Fix e2e tests by removing unecessary assertions & properly installing deps in api-fetch package #21780

Fix e2e tests by removing unecessary assertions & properly installing deps in api-fetch package #21780

Conversation

getdave commented Apr 22, 2020 • edited Loading

1. Unwanted deprecation notice assertions

2. Incorrectly installed dependency of @wordpress/api-fetch

How has this been tested?

On Master branch

On this PR's branch

Types of changes

Checklist:

github-actions bot commented Apr 22, 2020 • edited Loading

talldan left a comment

Choose a reason for hiding this comment

ockham commented Apr 22, 2020

getdave commented Apr 22, 2020 •

edited

Loading

github-actions bot commented Apr 22, 2020 •

edited

Loading