-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove /wordpress from test/linting ignore paths #20270
Remove /wordpress from test/linting ignore paths #20270
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for following up on this @johnwatkins0.
Perhaps the wordpress folder should also be removed from the .gitignore file now that it's not expected to be there. What do you think?
Thanks, @talldan. I agree -- if there's no longer anything in plugin development process that creates a |
Thank you for working on it. We should deprecate wp-scripts env first, before we land this PR. It is still referenced in some places in the root package.json of Gutenberg . In addition, if someone uses @wordpress/scripts and they run env script, they will see unexpected errors. |
@gziolo Ah, does that still install wordpress into a local folder? I didn't realise that. It looks like the older env is still used for travis, so that'd be one of the first places to replace with the newer Lines 83 to 99 in c76137b
|
It probably does. At least, it's what happens locally :) |
@johnwatkins0, we can land this changes now tfst There is also a note about ignored |
c674bc5
to
a4c9327
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 👍
Description
This resolves #20255 by removing
/wordpress
where it appears among linting/testing ignore patterns, essentially undoing everything in https://github.com/WordPress/gutenberg/pull/17296/files.Having
/wordpress/
in the ignore patterns was preventing Jest tests from being recognized when the project has/wordpress/
somewhere in the system directory path. According to @talldanin #20255 (comment), the original reason for ignoring the directory no longer applies, so it can be removed.
How has this been tested?
Ran linting and tests locally after the change. Everything worked.
Screenshots
Types of changes
Change to test and linting configurations.
Checklist: