Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove /wordpress from test/linting ignore paths #20270

Merged
merged 6 commits into from
Jan 3, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,4 @@ packages/block-serialization-spec-parser/parser.js
packages/e2e-tests/plugins
packages/react-native-editor/bundle
vendor
wordpress
!.*.js
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ gutenberg.zip
*.log
phpcs.xml
yarn.lock
/wordpress
/artifacts

.cache
Expand Down
6 changes: 3 additions & 3 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
/**
* Internal dependencies
*/
const DependencyExtractionWebpackPlugin = require( '../../..' );

module.exports = {
Expand Down
1 change: 0 additions & 1 deletion packages/e2e-tests/jest.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ module.exports = {
],
testPathIgnorePatterns: [
'/node_modules/',
'<rootDir>/wordpress/',
'e2e-tests/specs/performance/',
],
};
6 changes: 1 addition & 5 deletions packages/jest-preset-default/jest-preset.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,7 @@ module.exports = {
'**/test/*.[jt]s',
'**/?(*.)test.[jt]s',
],
testPathIgnorePatterns: [
'/node_modules/',
'<rootDir>/vendor/',
'<rootDir>/wordpress/',
],
testPathIgnorePatterns: [ '/node_modules/', '<rootDir>/vendor/' ],
timers: 'fake',
transform: {
'^.+\\.[jt]sx?$': require.resolve( 'babel-jest' ),
Expand Down
12 changes: 6 additions & 6 deletions packages/scripts/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ This is how you execute the script with presented setup:

When you run commands similar to the `npm run format:js:src` example above, you can provide a file, a directory, or `glob` syntax or any combination of them.

By default, files located in `build`, `node_modules`, `vendor` and `wordpress` folders are ignored.
By default, files located in `build`, `node_modules`, and `vendor` folders are ignored.

### `lint-js`

Expand All @@ -174,7 +174,7 @@ This is how you execute the script with presented setup:

When you run commands similar to the `npm run lint:js:src` example above, you can provide a file, a directory, or `glob` syntax or any combination of them. See [more examples](https://eslint.org/docs/user-guide/command-line-interface).

By default, files located in `build`, `node_modules`, `vendor` and `wordpress` folders are ignored.
By default, files located in `build`, `node_modules`, and `vendor` folders are ignored.

#### Advanced information

Expand Down Expand Up @@ -202,7 +202,7 @@ This is how you execute those scripts using the presented setup:

When you run commands similar to the `npm run lint:pkg-json:src` example above, you can provide one or multiple directories to scan as well. See [more examples](https://github.com/tclindner/npm-package-json-lint/blob/HEAD/README.md#examples).

By default, files located in `build`, `node_modules`, `vendor` and `wordpress` folders are ignored.
By default, files located in `build`, `node_modules`, and `vendor` folders are ignored.

#### Advanced information

Expand All @@ -226,7 +226,7 @@ This is how you execute the script with presented setup:

- `npm run lint:md:docs` - lints markdown files in the entire project’s directories.

By default, files located in `build`, `node_modules`, `vendor` and `wordpress` folders are ignored.
By default, files located in `build`, `node_modules`, and `vendor` folders are ignored.

#### Advanced information

Expand All @@ -250,7 +250,7 @@ This is how you execute the script with presented setup:

- `npm run lint:md:js` - lints markdown files in the entire project’s directories.

By default, files located in `build`, `node_modules`, `vendor` and `wordpress` folders are ignored.
By default, files located in `build`, `node_modules`, and `vendor` folders are ignored.

#### Advanced information

Expand Down Expand Up @@ -278,7 +278,7 @@ This is how you execute the script with presented setup:

When you run commands similar to the `npm run lint:css:src` example above, be sure to include the quotation marks around file globs. This ensures that you can use the powers of [globby](https://github.com/sindresorhus/globby) (like the `**` globstar) regardless of your shell. See [more examples](https://github.com/stylelint/stylelint/blob/HEAD/docs/user-guide/cli.md#examples).

By default, files located in `build`, `node_modules`, `vendor` and `wordpress` folders are ignored.
By default, files located in `build`, `node_modules`, and `vendor` folders are ignored.

#### Advanced information

Expand Down
1 change: 0 additions & 1 deletion packages/scripts/config/.eslintignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
build
node_modules
vendor
wordpress
1 change: 0 additions & 1 deletion packages/scripts/config/.stylelintignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,3 @@

build
vendor
wordpress
2 changes: 1 addition & 1 deletion packages/scripts/config/jest-e2e.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const { hasBabelConfig } = require( '../utils' );
const jestE2EConfig = {
preset: 'jest-puppeteer',
testMatch: [ '**/specs/**/*.[jt]s', '**/?(*.)spec.[jt]s' ],
testPathIgnorePatterns: [ '/node_modules/', '/wordpress/' ],
testPathIgnorePatterns: [ '/node_modules/' ],
reporters:
'TRAVIS' in process.env && 'CI' in process.env
? [
Expand Down
6 changes: 1 addition & 5 deletions test/native/jest.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,7 @@ module.exports = {
'**/test/*.native.[jt]s?(x)',
'<rootDir>/packages/react-native-*/**/?(*.)+(spec|test).[jt]s?(x)',
],
testPathIgnorePatterns: [
'/node_modules/',
'<rootDir>/wordpress/',
'/__device-tests__/',
],
testPathIgnorePatterns: [ '/node_modules/', '/__device-tests__/' ],
testURL: 'http://localhost/',
// Add the `Libraries/Utilities` subfolder to the module directories, otherwise haste/jest doesn't find Platform.js on Travis,
// and add it first so https://github.com/facebook/react-native/blob/v0.60.0/Libraries/react-native/react-native-implementation.js#L324-L326 doesn't pick up the Platform npm module.
Expand Down
1 change: 0 additions & 1 deletion test/unit/jest.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ module.exports = {
'/.git/',
'/node_modules/',
'/packages/e2e-tests',
'<rootDir>/wordpress/',
'<rootDir>/.*/build/',
'<rootDir>/.*/build-module/',
'<rootDir>/.+.native.js$',
Expand Down