Local changes on fresh clone install #8684
Assignees
Labels
Framework
Issues related to broader framework topics, especially as it relates to javascript
[Type] Automated Testing
Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Milestone
Comments
aduth
added
Framework
aduth
changed the title
ntwb
added a commit
that referenced
this issue
Aug 8, 2018
## Description Fixes #8684 ## How has this been tested? <!-- Please describe in detail how you tested your changes. --> <!-- Include details of your testing environment, tests ran to see how --> <!-- your change affects other areas of the code, etc. --> • Ensured my local Git repo was up to date with no changed files. ``` ❯ git status On branch master Your branch is up to date with 'origin/master'. nothing to commit, working tree clean ``` • Removed my local `node_modules` folder: ``` ❯ rm -i -rf node_modules/ ``` • Ran `npm install` ``` ❯ npm install ``` • Ran `git status` ``` ❯ git status On branch master Your branch is up to date with 'origin/master'. Changes not staged for commit: (use "git add <file>..." to update what will be committed) (use "git checkout -- <file>..." to discard changes in working directory) modified: package-lock.json no changes added to commit (use "git add" and/or "git commit -a") ``` • The `package-lock.json` diff is the same as @aduth notes in #8684 • Ran `npm test` ``` Test Suites: 1 skipped, 244 passed, 244 of 245 total Tests: 1 skipped, 2081 passed, 2082 total Snapshots: 74 passed, 74 total Time: 72.278s Ran all test suites. ``` ## Screenshots <!-- if applicable --> ## Types of changes <!-- What types of changes does your code introduce? --> <!-- Bug fix (non-breaking change which fixes an issue) --> <!-- New feature (non-breaking change which adds functionality) --> <!-- Breaking change (fix or feature that would cause existing functionality to not work as expected) --> Build Tools ## Checklist: - [x] My code is tested. - [x] My code follows the WordPress code style. <!-- Check code: `npm run lint`, Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/javascript/ --> - [x] My code follows the accessibility standards. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/ --> - [x] My code has proper inline documentation. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/ -->
|
It was sorted out with #8660 at last :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Regressed in #8596
To Reproduce
git clone https://github.com/WordPress/gutenberg.gitcd gutenbergnpm installnpm testgit statusIn other branches, I've been seeing errors on a failing snapshot test for DefaultBlockAppender . Not certain yet whether this is related. Will report back.
Expected behavior
The text was updated successfully, but these errors were encountered: