Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package-lock.json #8700

Merged
merged 2 commits into from
Aug 8, 2018
Merged

Update package-lock.json #8700

merged 2 commits into from
Aug 8, 2018

Conversation

ntwb
Copy link
Member

@ntwb ntwb commented Aug 8, 2018

Description

Fixes #8684

How has this been tested?

• Ensured my local Git repo was up to date with no changed files.

❯ git status
On branch master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean

• Removed my local node_modules folder:

❯ rm -i -rf node_modules/

• Ran npm install

❯ npm install

• Ran git status

❯ git status
On branch master
Your branch is up to date with 'origin/master'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

	modified:   package-lock.json

no changes added to commit (use "git add" and/or "git commit -a")

• The package-lock.json diff is the same as @aduth notes in #8684

• Ran npm test

Test Suites: 1 skipped, 244 passed, 244 of 245 total
Tests:       1 skipped, 2081 passed, 2082 total
Snapshots:   74 passed, 74 total
Time:        72.278s
Ran all test suites.

Screenshots

Types of changes

Build Tools

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@noisysocks
Copy link
Member

I was able to reproduce the failing default-block-appender test that we've been seeing in various Travis CI logs by pulling this branch and running rm -rf node_modules; npm install; npm test.

  ● DefaultBlockAppender › should append a default block when input focused

    expect(value).toMatchSnapshot()

    Received value does not match stored snapshot "DefaultBlockAppender should append a default block when input focused 1".

The test started failing because we're storing a snapshot of a React component that has a jest.fn() prop. Jest changed the internal shape of a MockFunction as part of Jest 23.4, which means that our test no longer matched the snapshot.

I've updated the snapshot in f8ebfeb.

@noisysocks noisysocks added the [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. label Aug 8, 2018
@noisysocks noisysocks added this to the 3.5 milestone Aug 8, 2018
Copy link
Member

@noisysocks noisysocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ntwb ntwb merged commit dd81e6b into master Aug 8, 2018
@ntwb ntwb deleted the update/lock-file branch August 8, 2018 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local changes on fresh clone install
2 participants