Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated dependencies: jest, npm-package-json-lint and read-pkg-up #8596

Merged
merged 1 commit into from
Aug 7, 2018

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented Aug 6, 2018

Description

This PR updates npm-package-json-lint to the latest version and adds newly introduced rules. Props to @tclindner for making it possible:

Hey! I just released v3.3.0 of npm-package-json-lint with a new description-format rule. It has two options:

requireCapitalFirstLetter - Throws an error if the first character in the description isn't capitalized.
requireEndingPeriod - Throws an error if the description doesn't end with a period.
Hopefully this works well for your team!

With this change, we can integrate new linting rule which will ensure that description inside package.json file will have proper formatting.

I took advantage of the fact that we are changing deps and bumped also jest which had also minor release.

I also downgraded read-pkg-up to avoid having it installed locally in the package. Instead, we can use the older version which is used with other packages. It doesn't break anything and keeps our setup simpler.

How has this been tested?

npm test should cover all tools.

@gziolo gziolo added [Type] Code Quality Issues or PRs that relate to code quality [Tool] WP Scripts /packages/scripts labels Aug 6, 2018
@gziolo gziolo added this to the 3.5 milestone Aug 6, 2018
@gziolo gziolo self-assigned this Aug 6, 2018
@gziolo gziolo requested review from ntwb and a team August 6, 2018 14:24
@gziolo
Copy link
Member Author

gziolo commented Aug 6, 2018

I also downgraded read-pkg-up to avoid having it installed locally in the package. Instead, we can use the older version which is used with other packages. It doesn't break anything and keeps our setup simpler.

Unless someone knows how to do the opposite and enforce 4.x in other places.

Copy link
Member

@ntwb ntwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet 👍

@ntwb ntwb merged commit c1ddfb2 into master Aug 7, 2018
@ntwb ntwb deleted the update/scripts-pkg-lint branch August 7, 2018 00:24
@aduth
Copy link
Member

aduth commented Aug 7, 2018

I think this missed some updates to package-lock.json. I'm seeing unrelated changes in #8660, which are also causing test failures for my branch.

@aduth
Copy link
Member

aduth commented Aug 7, 2018

See #8684

@gziolo
Copy link
Member Author

gziolo commented Aug 8, 2018

It was sorted out with #8660 at last.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Tool] WP Scripts /packages/scripts [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants