Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tracking] Font Library. Stage 1: Manage fonts and Local fonts upload #52698

Closed
14 of 16 tasks
mikachan opened this issue Jul 17, 2023 · 11 comments
Closed
14 of 16 tasks

[Tracking] Font Library. Stage 1: Manage fonts and Local fonts upload #52698

mikachan opened this issue Jul 17, 2023 · 11 comments
Labels
[Feature] Typography Font and typography-related issues and PRs [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.

Comments

@mikachan
Copy link
Member

mikachan commented Jul 17, 2023

Tracking issue for the Font Library
Stage 1: Manage fonts and Local fonts upload

The following list covers known features, bugs, and issues related to the Font Library. Ideally, we'll complete as many of these as possible before the 6.4 beta 1 (September 26, 2023).

To Do

In Progress

Done

Related

Next Steps:

Stage 2: #53307
Stage 3: #53926

@mikachan mikachan added [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues. [Feature] Typography Font and typography-related issues and PRs labels Jul 17, 2023
@matiasbenedetto matiasbenedetto changed the title Tracking: Font Library [Tracking] Fonts Library. Stage 1: Google and Local fonts Aug 2, 2023
@hellofromtonya hellofromtonya changed the title [Tracking] Fonts Library. Stage 1: Google and Local fonts [Tracking] Font Library. Stage 1: Google and Local fonts Aug 17, 2023
@hellofromtonya
Copy link
Contributor

Here's the Core Trac ticket https://core.trac.wordpress.org/ticket/59166 for tracking the merge of the Font Library into WordPress Core.

@matiasbenedetto
Copy link
Contributor

To reduce the scope of this issue a little by removing the Google fonts references from Stage 1 and adding it to Stage 2 tracking issue. It is to break up things into smaller pieces easier to think about, review, and merge. Both parts are still intended to be ready for WordPress 6.4

@matiasbenedetto matiasbenedetto changed the title [Tracking] Font Library. Stage 1: Google and Local fonts [Tracking] Font Library. Stage 1: Manage fonts and Local fonts upload Aug 22, 2023
@azaozz
Copy link
Contributor

azaozz commented Aug 28, 2023

There have been questions/discussions about why the font previews in the UI don't use images (SVGs) but instead load the (whole) fonts from Google. It seems that using SVGs has some significant advantages:

  1. Makes the Font Library quite faster when browsing fonts to install.
  2. Fixes/removes the need to access the Google fonts CDN when browsing. That removes the need to ask for user consent every time the users look for new fonts in the Font Library (i.e. removes the need to have an intermediate "stop and ask for consent" stage). The SVG images can be hosted on wp.org together with the (updated) fonts list, or perhaps even be part of the list (several possible implementations).

Looking at the three stages: this issue, #53307 and #53926, it seems that using images for previews may be intended for stage 3. However thinking that implementing this enhancement now would make the Font Library quite better, and will help to alleviate some of the user privacy concerns. (There was a court case in EU over loading fonts from the Google CDN, hence there must be a "a blocking step/dialog/popup to ask for used consent" before loading fonts from there in the Font Library).

@jasmussen
Copy link
Contributor

(There was a court case in EU over loading fonts from the Google CDN, hence there must be a "a blocking step/dialog/popup to ask for used consent" before loading fonts from there in the Font Library)

Just want to boost for visibility, as this keeps coming up, that in #53882 there is such a design requiring opt-in before you load anything at all. It seems like it would be very easy to implement, so let me know if that doesn't address the concern shared.

Add fonts from Google, option 4

@webd-uk
Copy link

webd-uk commented Aug 29, 2023

Should the notice not explain a little about why permission is required in that doing so exposes your IP to a third party who may use it to track you? “Giving permission to connect” isn’t the same as “giving permission to connect and expose your IP to whatever.third.party.server”.

@jasmussen
Copy link
Contributor

Yes, I would love advice on the exact phrasing. In my opinion, this notice can be as big and scary as it needs to be, so long as there's a single clear button that takes you to the next step.

@matiasbenedetto
Copy link
Contributor

There have been questions/discussions about why the font previews in the UI don't use images (SVGs) but instead load the (whole) fonts from Google. It seems that using SVGs has some significant advantages:

  1. Makes the Font Library quite faster when browsing fonts to install.
  2. Fixes/removes the need to access the Google fonts CDN when browsing.

Yes, we could load the SVG images as previews without hassle. I agree it's a good enhancement. However, I would prefer to think about that as a performance improvement and not correlate it to the GDPR legislation discussion because we would still need to load the font assets from Google to generate the custom text previews when we re-enable that feature.

@azaozz
Copy link
Contributor

azaozz commented Aug 29, 2023

I would prefer to think about that as a performance improvement and not correlate it to the GDPR legislation discussion because we would still need to load the font assets from Google...

Right. Using images will not remove the need for loading fonts from Google for custom previews, but will reduce (quite significantly?) the number of times that may be needed. Fonts can also be installed without custom previews, right?

@azaozz
Copy link
Contributor

azaozz commented Aug 29, 2023

Yes, I would love advice on the exact phrasing. In my opinion, this notice can be as big and scary as it needs to be

This looks great imho. One suggestion about the text: thinking it has to give the users an alternative. As it is currently the message can be perceived as "either give permission or fonts cannot be installed". This, of course, is not the case :)

@jasmussen
Copy link
Contributor

Thanks. I took that feedback into consideration and updated the mockups in the main issue: #45271.

@matiasbenedetto
Copy link
Contributor

I'm closing this issue because this stage was part of the plan to make the font library ready to merge in WordPress core 6.4, but since it was punted to 6.5, we should focus on making it ready for 6.5. This is the new tracking issue: #55277

@github-project-automation github-project-automation bot moved this from Punted to 6.5 to Done in WordPress 6.4 Editor Tasks Oct 11, 2023
@matiasbenedetto matiasbenedetto closed this as not planned Won't fix, can't repro, duplicate, stale Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Typography Font and typography-related issues and PRs [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.
Projects
No open projects
Status: Done
Development

No branches or pull requests

6 participants