Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "Fonts Library" to "Font Library" #53778

Closed
hellofromtonya opened this issue Aug 17, 2023 · 3 comments · Fixed by #53780
Closed

Rename "Fonts Library" to "Font Library" #53778

hellofromtonya opened this issue Aug 17, 2023 · 3 comments · Fixed by #53780
Labels
[Feature] Typography Font and typography-related issues and PRs [Type] Enhancement A suggestion for improvement.

Comments

@hellofromtonya
Copy link
Contributor

What problem does this address?

The library's name originally was coined as singular form, i.e. "Font Library". Along the way, it changed to the plural form of "Fonts".

The plural form aligns well to font foundries like Google Fonts, Adobe Fonts, Bunny Fonts, etc.

The singular form aligns well to other WordPress-specific libraries and directories, such as:

  • Block Library
  • Pattern Library
  • Media Library
  • Photo Directory

Props to @ironprogrammer for raising the singular form relationship to the above list.

What is your proposed solution?

Rename to use the singular form. Instead of "Fonts Library", rename to "Font Library".

Changes:

  • The merged PHP backend files:
    • lib/experimental/fonts/fonts-library becomes lib/experimental/fonts/font-library.
    • WP_Fonts_Library becomes WP_Font_Library and its filename changes too.
    • WP_REST_Fonts_Library_Controller becomes WP_REST_Font_Library_Controller plus its filename.
    • and the associated tests.
  • All open issues.
  • Rename in frontend work Font Library: Frontend #53650.

Part of #52698.

@hellofromtonya
Copy link
Contributor Author

@matiasbenedetto do you agree with the rename?

@matiasbenedetto
Copy link
Contributor

matiasbenedetto commented Aug 17, 2023

@matiasbenedetto do you agree with the rename?

Yes, sounds good to me. :shipit:

@hellofromtonya
Copy link
Contributor Author

Also noting @mikachan prefers the singular form too. Here's a quote from Sarah from a Slack discussion:

I also prefer "Font Library"

@mikachan mikachan linked a pull request Aug 18, 2023 that will close this issue
@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Typography Font and typography-related issues and PRs [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants