Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fonts Library: update properties name from snake case to camel case to match the rest of the properties #53746

Merged
merged 4 commits into from
Aug 16, 2023

Conversation

matiasbenedetto
Copy link
Contributor

@matiasbenedetto matiasbenedetto commented Aug 16, 2023

What?

Fonts Library: update properties name from snake case to camel case
download_from_url to downloadFromUrl
uploaded_file to uploadedFile

Why?

To match the rest of the properties.

@matiasbenedetto matiasbenedetto added the [Type] Code Quality Issues or PRs that relate to code quality label Aug 16, 2023
@github-actions
Copy link

github-actions bot commented Aug 16, 2023

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files
❔ lib/experimental/fonts-library/class-wp-font-family.php
❔ lib/experimental/fonts-library/class-wp-rest-fonts-library-controller.php
❔ phpunit/fonts-library/class-wp-rest-fonts-library-controller-test.php
❔ phpunit/fonts-library/wpFontFamily/base.php
❔ phpunit/fonts-library/wpFontFamily/getData-test.php
❔ phpunit/fonts-library/wpFontFamily/install-test.php
❔ phpunit/fonts-library/wpFontFamily/uninstall-test.php

@matiasbenedetto matiasbenedetto changed the title Fonts Library: update properties name from snake case to camel case to math the rest of the properties Fonts Library: update properties name from snake case to camel case to match the rest of the properties Aug 16, 2023
@hellofromtonya
Copy link
Contributor

Conflicting files
phpunit/fonts-library/class-wp-font-family-test.php

I just merged the PR #53702 (67454a0) that improves the tests. trunk needs to be merged into this PR to get rid of the merge conflict.

Copy link
Contributor

@hellofromtonya hellofromtonya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the properties makes sense for consistency. Good catch @matiasbenedetto! Changes LGTM 👍

@hellofromtonya hellofromtonya merged commit 1ea396a into trunk Aug 16, 2023
@hellofromtonya hellofromtonya deleted the rename-fonts-library-json-properties branch August 16, 2023 18:55
@github-actions github-actions bot added this to the Gutenberg 16.6 milestone Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants