Add edits data to the useEntityRecord #54167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matiasbenedetto
added
[Type] Enhancement
This was referenced Sep 5, 2023
|
Size Change: +21 B (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 5b4ac31. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6079354743
|
mikachan
reviewed
Sep 6, 2023
|
Thanks for the ping, @mikachan. @matiasbenedetto, what would be the use case of the |
|
Hi thanks both for taking a look!
@Mamaduka the use case would be to know if some specific object path has changed. In this way, we would be able to detect and later on, save only the changes on the specified object path using __experimentalSaveSpecifiedEntityEdits() as we are doing in this Font Library PR: #53884 |
Mamaduka
approved these changes
Sep 6, 2023
There was a problem hiding this comment.
Thanks for the additional details, @matiasbenedetto!
The changes here look good to me 👍
bph
added
the
Needs Dev Note
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Get the edits from an entity record using the
useEntityRecordhook.Why?
Currently, we can know if the entity has edits or not. With this change, we are getting the edits from the entity.
How?
By returning a
editskey in the output of theuseEntityRecordhook containing the nonTransientEdits of an entity record.Testing Instructions
Expected result: