Rename atomic.notify, *.atomic.wait #1564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomic.notify -> memory.atomic.notify i32.atomic.wait -> memory.atomic.wait32 i64.atomic.wait -> memory.atomic.wait64 These were renamed upstream a while ago, but the new names were not added to wabt.
sbc100
approved these changes
Nov 3, 2020
aheejin
added a commit
to aheejin/wabt
that referenced
this pull request
Dec 19, 2021
This finishes WebAssembly#985 by dropping support for the deprecated names and update old names in tests. WebAssembly#985 says the old names are supported for convenience but we should remove those too at some point; that "some point" may have well arrived given that three years have passed. The list of names updated is in WebAssembly#933 and WebAssembly#1564.
aheejin
added a commit
to aheejin/wabt
that referenced
this pull request
Dec 19, 2021
This finishes WebAssembly#985. This - replaces renaming the old names in the tests with the new names - updates more instruction names: `memory.size` and `memory.grow` - drops support for the deprecated names - renames test files to match new instruction names I don't think dropping support for the old names will be a problem at this point. WebAssembly#985 says the old names are supported for convenience but we should remove those too at some point; that "some point" may have well arrived given that three years have passed. The lists of names updated are in WebAssembly#933, WebAssembly#1564, WebAssembly/spec#720.
aheejin
added a commit
to aheejin/wabt
that referenced
this pull request
Dec 20, 2021
This finishes WebAssembly#985. This - replaces renaming the old names in the tests with the new names - updates more instruction names: `memory.size` and `memory.grow` - drops support for the deprecated names - renames test files to match new instruction names I don't think dropping support for the old names will be a problem at this point. WebAssembly#985 says the old names are supported for convenience but we should remove those too at some point; that "some point" may have well arrived given that three years have passed. The lists of names updated are in WebAssembly#933, WebAssembly#1564, WebAssembly/spec#720.
aheejin
added a commit
to aheejin/wabt
that referenced
this pull request
Dec 20, 2021
This finishes WebAssembly#985. This - replaces the old names in the tests with the new names - drops support for the deprecated names - renames test files to match new instruction names I don't think dropping support for the old names will be a problem at this point. WebAssembly#985 says the old names are supported for convenience but we should remove those too at some point; that "some point" may have well arrived given that three years have passed. The lists of names updated are in WebAssembly#933, WebAssembly#1564, WebAssembly/spec#720.
aheejin
added a commit
that referenced
this pull request
Dec 21, 2021
This finishes #985. This - replaces the old names in the tests with the new names - drops support for the deprecated names - renames test files to match new instruction names I don't think dropping support for the old names will be a problem at this point. #985 says the old names are supported for convenience but we should remove those too at some point; that "some point" may have well arrived given that three years have passed. The lists of names updated are in #933, #1564, WebAssembly/spec#720.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
atomic.notify -> memory.atomic.notify
i32.atomic.wait -> memory.atomic.wait32
i64.atomic.wait -> memory.atomic.wait64
These were renamed upstream a while ago, but the new names were not
added to wabt.