Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark explainer as outdated #165

Closed
wants to merge 1 commit into from
Closed

Mark explainer as outdated #165

wants to merge 1 commit into from

Conversation

surma
Copy link

@surma surma commented Oct 2, 2020

No description provided.

@conrad-watt
Copy link
Collaborator

Is this referring specifically to the text format? Which parts have become outdated?

@surma
Copy link
Author

surma commented Oct 2, 2020

Yes, the text format is not up-to-date (memory.atomic.wait32, for example). I haven’t checked if anything else is out of date.

@conrad-watt
Copy link
Collaborator

We've generally been careful to keep the overview up to date, in lieu of a formal spec. The naming convention for atomics.wait was explicitly changed relatively recently (#145). AFAIK, memory.atomic.wait32 is the modern mnemonic.

@surma
Copy link
Author

surma commented Oct 2, 2020

I was assuming the spec is correct and not the explainer as wabt (or wat2wasm --enable-threads more specifically) recognizes i32.atomic.wait but not memory.atomic.wait32.

Feel free to disregard my PR if I tackled the problem from the wrong end. I was just confused by the current state of spec vs explainer vs tooling.

@conrad-watt
Copy link
Collaborator

The formatted spec at https://webassembly.github.io/threads has now been updated with the modern mnemonics. I don't know if @binji has any information about wabt?

@binji
Copy link
Member

binji commented Nov 3, 2020

I'm kinda surprised, since I thought I updated these names in wabt, but it seems not. I'll update.

EDIT: WebAssembly/wabt#1564

@conrad-watt
Copy link
Collaborator

@surma are you happy for this to be closed now that wabt has been updated? Please let us know if you're still dealing with inconsistencies.

@surma
Copy link
Author

surma commented Nov 26, 2020

Absolutely. Cheers.

@surma surma closed this Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants