[spec] Rename memory instructions (long names) #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 27, 2018
cretz
added a commit
to cretz/asmble
that referenced
this pull request
May 7, 2018
* Added LEB128 validation (ref: WebAssembly/spec#750) * Rename memory instructions (ref: WebAssembly/spec#720)
sunfishcode
added a commit
to sunfishcode/wasmparser.rs
that referenced
this pull request
Jun 7, 2018
The wasm instructions `grow_memory` and `current_memory` were renamed to `memory.grow` and `memory.size`, respectively: WebAssembly/spec#720 The patch here renames wasmparser.rs's `GrowMemory` and `CurrentMemory` to `MemoryGrow` and `MemorySize`, to better align with the spec.
sunfishcode
added a commit
to sunfishcode/wasmparser.rs
that referenced
this pull request
Jun 7, 2018
The wasm instructions `grow_memory` and `current_memory` were renamed to `memory.grow` and `memory.size`, respectively: WebAssembly/spec#720 The patch here renames wasmparser.rs's `GrowMemory` and `CurrentMemory` to `MemoryGrow` and `MemorySize`, to better align with the spec.
joyeecheung
pushed a commit
to joyeecheung/v8
that referenced
this pull request
Nov 5, 2018
The "grow_memory" opcode was renamed to "memory.grow", and the spec repo was updated to use kExprMemoryGrow internally instead of kExprGrowMemory (WebAssembly/spec#720). This CL does the same change for v8. Drive-by: Rename "current_size" to "memory.size", and a minor cleanup in wasm-graph-builder.js to bring it in line with the version in the js-api tests in the spec repo. [email protected] Change-Id: If525dba898b2c248890a616d3392c22b45f698ef Reviewed-on: https://chromium-review.googlesource.com/c/1302057 Reviewed-by: Ben Titzer <[email protected]> Commit-Queue: Clemens Hammacher <[email protected]> Cr-Commit-Position: refs/heads/master@{#57089}
aheejin
added a commit
to aheejin/wabt
that referenced
this pull request
Dec 19, 2021
This finishes WebAssembly#985. This - replaces renaming the old names in the tests with the new names - updates more instruction names: `memory.size` and `memory.grow` - drops support for the deprecated names - renames test files to match new instruction names I don't think dropping support for the old names will be a problem at this point. WebAssembly#985 says the old names are supported for convenience but we should remove those too at some point; that "some point" may have well arrived given that three years have passed. The lists of names updated are in WebAssembly#933, WebAssembly#1564, WebAssembly/spec#720.
aheejin
added a commit
to aheejin/wabt
that referenced
this pull request
Dec 20, 2021
This finishes WebAssembly#985. This - replaces renaming the old names in the tests with the new names - updates more instruction names: `memory.size` and `memory.grow` - drops support for the deprecated names - renames test files to match new instruction names I don't think dropping support for the old names will be a problem at this point. WebAssembly#985 says the old names are supported for convenience but we should remove those too at some point; that "some point" may have well arrived given that three years have passed. The lists of names updated are in WebAssembly#933, WebAssembly#1564, WebAssembly/spec#720.
aheejin
added a commit
to aheejin/wabt
that referenced
this pull request
Dec 20, 2021
This finishes WebAssembly#985. This - replaces the old names in the tests with the new names - drops support for the deprecated names - renames test files to match new instruction names I don't think dropping support for the old names will be a problem at this point. WebAssembly#985 says the old names are supported for convenience but we should remove those too at some point; that "some point" may have well arrived given that three years have passed. The lists of names updated are in WebAssembly#933, WebAssembly#1564, WebAssembly/spec#720.
aheejin
added a commit
to WebAssembly/wabt
that referenced
this pull request
Dec 21, 2021
This finishes #985. This - replaces the old names in the tests with the new names - drops support for the deprecated names - renames test files to match new instruction names I don't think dropping support for the old names will be a problem at this point. #985 says the old names are supported for convenience but we should remove those too at some point; that "some point" may have well arrived given that three years have passed. The lists of names updated are in #933, #1564, WebAssembly/spec#720.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to PR #649 for addressing #627. Instead of shortening all
memorytomemit keeps the long names and only renames:current_memory -> memory.size
grow_memory -> memory.grow
It also adapts all tests; much fewer test are affected than by #649.