Make NAV run on Django 3.2 #2313
Conversation
In order for the tests to run at all, six must be working. Better to do a global change that temporarily fixes the problem everywhere and then get rid of six, then having to reanalyse all places that uses six while the tests are not working. As long as we support Django 2.2, which is the last to support Python 2.7, we need something like six. When we no longer support 2.2, we can get rid of six *and all other workrounds for running on Python 2.7 and Python 3 at the same time* in a "stop supporting python 2.7"-branch.
NAV depends on DRF older than 3.10, which don't support newer Django's and Python's. * Use drf 3.8's "action" instead *_route * Rename drf base_name to basename to support drf > 3.9
Django 2.2 has *_text, Django 3.2 has both, Django 4.0 has *_str. Gets rid of a warning.
Newest crispy-forms might not work with Django 2.2 so we have to wait.
.. as in: supported since Django 2.2. It might be that repr()-ing any Response is also safe now and that the test-function is no longer needed.
Gets rid of the following warnings:
RemovedInDjango40Warning:
The {% ifequal %} template tag is deprecated in favor of {% if %}.
RemovedInDjango40Warning:
The {% ifnotequal %} template tag is deprecated in favor of {% if %}.
Gets rid of warning: RemovedInDjango40Warning: django.conf.urls.url() is deprecated in favor of django.urls.re_path().
Gets rid of warning:
models.TimePeriod: (models.W042) Auto-created primary key used when not
defining a primary key type, by default 'django.db.models.AutoField'.
HINT: Configure the DEFAULT_AUTO_FIELD setting or the
NavModelsConfig.default_auto_field attribute to point to
a subclass of AutoField, e.g. 'django.db.models.BigAutoField'.
Gets rid of exception on Django 3.2: AttributeError: module 'django.forms.forms' has no attribute 'pretty_name'
Also Import lru_cache from seddable place
|
This PR will be split into multiple smaller PRs for ease of review. |
|
First PR to merge: #2315. Does not need Django 3.2 to run but prevents exceptions when later testing on 3.2. |
|
Second PR, can be merged independently from the first: #2316. Upgrade dependencies that need changes in our code. |
|
Third PR, depends on the two previous PRs: #2317. Upgrades the actual code, and runs the tests on 3.2 in addition to 2.2. |
|
Note how judicious (ab)use of |
|
Given that all the split PRs have been reviewed and merged, I assume this combined one can be closed now. Thank you! |
No description provided.