Properly upgrade to Django 2.2 #2315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use Python's own lru_cache if available lru_cache() was added to functools in Python 3.2. * Rename (force|smart)_text to (force|smart)_str Django 2.2 has *_text, Django 3.2 has both, Django 4.0 has *_str. Gets rid of a warning.
We no longer need support Django older than 2.2, so switch to the header access method introduced in Django 1.11.
hmpf
force-pushed
the
correct-django-22
branch
from
8cbb01e to
d1adb0e
Compare
Merged
lunkwill42
requested changes
Nov 25, 2021
|
I made a PR #2330 to ensure that no syntax errors or missing imports are ever commited. I don't think it is a test's job to ensure there are no typos when there are faster and better ways to find and prevent them. |
lunkwill42
approved these changes
Nov 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the code currently runs on 2.2, it is not doing everything as 2.2 would prefer.
Merging this PR will improve code quality on 2.2 and prevent exceptions on 3.2.
A new module
nav.compatibilityis introduced, to do some conditional imports in a single location, similar tosix.moves. When 2.2 is no longer supported this file can be removed after updating to the modern locations:lru_cachefromfunctools,force_str/smart_strfromdjango.utils.encoding.