Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade dependencies that will need a newer version to run on Django 3.2 or later #2316

Merged
merged 2 commits into from
Nov 26, 2021
Merged

Upgrade dependencies that will need a newer version to run on Django 3.2 or later #2316

merged 2 commits into from
Nov 26, 2021

Conversation

hmpf
Copy link
Contributor

@hmpf hmpf commented Oct 22, 2021

No description provided.

@hmpf hmpf requested a review from lunkwill42 October 22, 2021 09:33
@hmpf hmpf mentioned this pull request Oct 22, 2021
Closed
@github-actions
Copy link

github-actions bot commented Oct 22, 2021 •
edited
Loading

Test results

       6 files         6 suites   8m 32s ⏱️
2 800 tests 2 704 ✔️   96 💤 0 ❌
5 600 runs  5 408 ✔️ 192 💤 0 ❌

Results for commit 605afa2.

♻️ This comment has been updated with latest results.

@hmpf hmpf mentioned this pull request Oct 22, 2021
Merged
lunkwill42
lunkwill42 requested changes Nov 25, 2021
View reviewed changes
Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems pretty straightforward. I feel like I've made those action decorator replacements in NAV once before.. did they change more than once in DRF history?

Fix the dependency issue, and I think this is good to go :)

requirements/base.txt Show resolved Hide resolved
@hmpf
Copy link
Contributor Author

hmpf commented Nov 26, 2021

Seems pretty straightforward. I feel like I've made those action decorator replacements in NAV once before.. did they change more than once in DRF history?

It seems to me that everyone involved with the dev of the Django ecosystem are very fond of renaming things, usually without any other changes. Notice the adding and removal of underlines. basename <=> base_name, get_queryset <=> get_query_set, stuff like that.

hmpf added 2 commits November 26, 2021 09:35
@hmpf
Migrate to django-rest-framework 3.12
86a5f3e 
NAV depends on DRF older than 3.10, which don't support newer
Django's and Python's.

* Use drf 3.8's "action" instead *_route
* Rename drf base_name to basename to support drf > 3.9
* Document why we still need markdown, no longer a required dependency of drf
@hmpf
Migrate to django-filter 2.x
605afa2
@hmpf
Copy link
Contributor Author

hmpf commented Nov 26, 2021

Dependency fixed.

@lunkwill42 lunkwill42 added this to the 5.3.0 milestone Nov 26, 2021
@lunkwill42 lunkwill42 merged commit 073a6ce into Uninett:master Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunkwill42 lunkwill42 lunkwill42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@hmpf @lunkwill42