Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for guiser interaction with armor, alerts #1792

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

nearbear
Copy link
Contributor

@nearbear nearbear commented Dec 18, 2024

For: #22

  • Fixed guiser going thru armor immunity. It was the same bug in nature as the turncoat bug from Fixed turncoat guiser kill interaction #1782 so I tried a different approach to fixing it this time. The dominates check for identity stealer should no longer cause immune events.
  • Fixed alerts being given to the wrong player when guising occurred; swapIdentity now additionally swaps the recipients of alerts that are presently queued.
  • Added some guiser tests. The sockets.js change supports this because it's a necessary function for swapIdentity.

Tested the alerts issue locally by having the gunsmith give a gun to a cop then verifying that when they were guised, the dead player received the alert for the gun and not the guiser.

@Golbolco Golbolco merged commit d3b259e into UltiMafia:master Dec 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants