Fixed turncoat guiser kill interaction #1782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Golbolco
added a commit
that referenced
this pull request
Dec 18, 2024
For: #22 - Fixed guiser going thru armor immunity. It was the same bug in nature as the turncoat bug from #1782 so I tried a different approach to fixing it this time. The dominates check for identity stealer should no longer cause immune events. - Fixed alerts being given to the wrong player when guising occurred; swapIdentity now additionally swaps the recipients of alerts that are presently queued. - Added some guiser tests. The sockets.js change supports this because it's a necessary function for swapIdentity. Tested the alerts issue locally by having the gunsmith give a gun to a cop then verifying that when they were guised, the dead player received the alert for the gun and not the guiser. Co-authored-by: Golbolco <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As is, guiser voting yes to steal identity while targeting a turncoat with mafia meeting will convert them into a traitor then kill them.
Turncoat would listen to the emitted immune event when guiser steal identity action checks for immunity, causing the conversion to happen sooner in priority than maf kill. Adding temp immunity allows turncoat to keep its mafia immunity for the entire night that it gets converted.