Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(mafia): compiled disguiser bugs #22

Open
6 tasks
pikulet opened this issue May 10, 2023 · 1 comment
Open
6 tasks

bug(mafia): compiled disguiser bugs #22

pikulet opened this issue May 10, 2023 · 1 comment
Labels
bug Something isn't working game/mafia Mafia, role mechanics help wanted Need help on issue

Comments

@pikulet
Copy link
Contributor

pikulet commented May 10, 2023

  • end of game spams chat with "you are speaking too quickly"

  • vegged guiser reveals the wrong role

image
guiser went on vegged doctor
daniel's role should show doctor, pikulet's role should show ?

  • vested target will die to guiser

This is even if the vesting happens n1 and the guisekill happens n2.

  • alerts are given to the guiser

image

  • This is the disguiser's view; the cop died and he got the report.

  • The guiser can now view investigative reports and "You received XX item" reports from the target.

  • For items e.g. gun, guiser gets the You received XX message but does not actually have the gun.

  • the guised person can see who the guiser is

image

This is the dead cop's view, he can see the guiser's role icon. Might affect gy mechanics.

  • guise does not happen
  • guisekilled vested BP, and someone else killed BP
  • result is no guise
@pikulet pikulet added bug Something isn't working help wanted Need help on issue game/mafia Mafia, role mechanics labels May 10, 2023
@pikulet
Copy link
Contributor Author

pikulet commented May 10, 2023

by sharky

Setup: 1 res, 1 vig, 3 vill, 1 guiser, 1 mafioso

n0: vig: vote NO, mafia: kill 1 vill, guiser: vote YES, res: vote NO
d1: ALL: vote NO
n1: vig: kill guiser, maf: vote NO KILL, guiser: vote NO, res: REVIVE DEAD

RESULT: original guiser target is still dead, guiser alive as original self, but shows CLEAR BLUE?
d2: ALL VOTE ORIGINAL GUISER: "GUISER EXECUTED, ROLE WAS DISGUISER"

Golbolco added a commit that referenced this issue Dec 18, 2024
For: #22

- Fixed guiser going thru armor immunity. It was the same bug in nature
as the turncoat bug from
#1782 so I tried a different
approach to fixing it this time. The dominates check for identity
stealer should no longer cause immune events.
- Fixed alerts being given to the wrong player when guising occurred;
swapIdentity now additionally swaps the recipients of alerts that are
presently queued.
- Added some guiser tests. The sockets.js change supports this because
it's a necessary function for swapIdentity.

Tested the alerts issue locally by having the gunsmith give a gun to a
cop then verifying that when they were guised, the dead player received
the alert for the gun and not the guiser.

Co-authored-by: Golbolco <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working game/mafia Mafia, role mechanics help wanted Need help on issue
Projects
None yet
Development

No branches or pull requests

1 participant