-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
328/cran resubmission/remove osf tests #339
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
@d-morrison This ready for review and merging! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there! I suggested one change below.
Co-authored-by: Douglas Ezra Morrison <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great - thanks!
Updated tests to use internal testing datasets instead of OSF. @d-morrison I need help with test-class_attributes.R, test-f_dev.R, and test-stratify_data.R.