Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

328/cran resubmission/remove osf tests #339

Merged
merged 10 commits into from
Jan 23, 2025

Conversation

kristinawlai
Copy link
Collaborator

Updated tests to use internal testing datasets instead of OSF. @d-morrison I need help with test-class_attributes.R, test-f_dev.R, and test-stratify_data.R.

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

see 2 files with indirect coverage changes

@kristinawlai kristinawlai marked this pull request as ready for review January 23, 2025 00:25
@kristinawlai
Copy link
Collaborator Author

@d-morrison This ready for review and merging!

Copy link
Member

@d-morrison d-morrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! I suggested one change below.

tests/testthat/test-stratify_data.R Outdated Show resolved Hide resolved
@d-morrison d-morrison self-requested a review January 23, 2025 01:35
Copy link
Member

@d-morrison d-morrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - thanks!

@d-morrison d-morrison merged commit 78c3ea6 into main Jan 23, 2025
13 of 14 checks passed
@d-morrison d-morrison deleted the 328/CRAN-resubmission/remove-osf-tests branch January 23, 2025 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants