Amperize issues #9022
Assignees
Labels
bug
[triage] something behaving unexpectedly
server / core
Issues relating to the server or core of Ghost
Comments
aileen
added
bug
|
@AileenCGN
Is that a hard thing to fix? Otherwise, assign a PR to me in amperize and then we can close this issue 👻 |
aileen
added a commit
to aileen/Ghost
that referenced
this issue
Jan 4, 2018
closes TryGhost#9022 Images without extensions don't need to be manipulated, as we're now reading the bytes and pass those to the `image-size` lib. This PR adds another `user-agent` to emulate multiple browser requests, as I stumbled over an example where the image without extension is protected otherwise. Added a test, that works with above mentioned image, but is currently mocked. Nevertheless, the image worked as a PoC, that we're able to read the bytes of an image without its extension and still return the dimensions of the image.
kirrg001
pushed a commit
that referenced
this issue
Jan 4, 2018
closes #9022 Images without extensions don't need to be manipulated, as we're now reading the bytes and pass those to the `image-size` lib. This PR adds another `user-agent` to emulate multiple browser requests, as I stumbled over an example where the image without extension is protected otherwise. Added a test, that works with above mentioned image, but is currently mocked. Nevertheless, the image worked as a PoC, that we're able to read the bytes of an image without its extension and still return the dimensions of the image.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue Summary
We detected three major problems within the Amperize repository:
Images without extension
Images like this https://www.zomato.com/logo/18163505/minilogo work, but don't have an extension and will therefore cause an error in the underlying
image-sizelibrary.One image fails all
If one image fails to load, none are loaded. This is simple to test by adding an image (open amp page) then add another image with a made up name and view the amp page again. Both images are missing.
Redirects are not followed
Redirected image URLs are not followed. Within Ghost (where we use a similar logic to fetch image dimension), we fixed this by changing to
gotfor our requests. See 🙈 Usedgotto handle requests for image-size #8953 and the follow up PR ✨ Request util to wrapgotlibrary #8980.Todos/Sub-issues
image-sizelibrary jbhannah/amperize#97Note: I created a new repository which is fixed the above mentioned issues. It is possible to either port those changes to the Amperize repository, my fork of it, or using the new repository. All dependent on how the repository owner plans to keep maintaining it or not.
The text was updated successfully, but these errors were encountered: