🙈 Used got to handle requests for image-size
#8953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs TryGhost#8589 refs TryGhost#8868 Swap `request` with `got` in `getImageSizeFromUrl` fn.
aileen
force-pushed
the
lts-refactor-image-size-use-got
branch
from
c604e1b to
f26bb9d
Compare
no issue This PR includes a new util which wraps the `got` library. It is not used in the codebase yet, but tested with `image-size` util: - wraps `got` request library in its own `request.js` util that returns bluebird promises and validates URL before starting a request - adds tests
no issue - swapped the usage of `got` for requests with the request util
aileen
force-pushed
the
lts-refactor-image-size-use-got
branch
4 times, most recently
from
9aab8fb to
653665b
Compare
no issue - Used catch predicates instead of conditionals in `getImageSizeFromUrl` - Returned `NotFoundError` if applicable as the caller function `cachedImageSizeFromUrl` is differentiating those between this error and others. - The logic that checked for an existing protocol (e. g. gravatar URLs) was overly complicated. Refactored it to be more simple. - added more tests
no issue We're always resolving the result in `getCachedImageSizeFromUrl`, so there's no need to return the values with a `Promise.resolve()`. The caller fn uses waits for the Promises to be fulfilled.
aileen
force-pushed
the
lts-refactor-image-size-use-got
branch
from
653665b to
aee0ac4
Compare
This was referenced Sep 13, 2017
Closed
|
@AileenCGN Can you pls PR the AMP bump to LTS? |
|
Will test all edge cases on staging before the public release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8589
refs #8868
This PR ports most of the changes of #8892 and #8986 to improve the image-size util.
requestwithgotingetImageSizeFromUrlfn.gotrequest library in its ownrequest.jsutil that returns bluebird promises and validates URL before starting a requestgetImageSizeFromUrlNotFoundErrorif applicable as the caller functioncachedImageSizeFromUrlis differentiating those between this error and others.getCachedImageSizeFromUrl, so there's no need to return the values with aPromise.resolve(). The caller fn uses waits for the Promises to be fulfilled.