Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow redirects for images #99

Closed
aileen opened this issue Sep 8, 2017 · 0 comments · Fixed by #101
Closed

Follow redirects for images #99

aileen opened this issue Sep 8, 2017 · 0 comments · Fixed by #101

Comments

@aileen
Copy link
Collaborator

aileen commented Sep 8, 2017

Currently we're using https or http to make requests to read the image buffer and then pass it to image-size. These don't follow redirects. The library got follows redirects and would simplify the request a lot.

With TryGhost/Ghost#8892 we switched to the got library for the very same task and are very happy with it. I suggest doing the same here.
aileen added a commit to aileen/amperize that referenced this issue Sep 13, 2017
@aileen
✨ Replace http and https with got
0318baa 
closes jbhannah#99

- Used [`got`](https://github.com/sindresorhus/got) for image-size requests, which is more lightweight and has the huge advantage of following redirects
- Added and updated test
aileen added a commit to aileen/amperize that referenced this issue Sep 13, 2017
@aileen
✨ Replace http and https with got
6a76e80 
closes jbhannah#99

- Used [`got`](https://github.com/sindresorhus/got) for image-size requests, which is more lightweight and has the huge advantage of following redirects
- Added and updated test
aileen added a commit to aileen/amperize that referenced this issue Sep 13, 2017
@aileen
✨ Replace http and https with got
9638035 
closes jbhannah#99

- Used [`got`](https://github.com/sindresorhus/got) for image-size requests, which is more lightweight and has the huge advantage of following redirects
- Added and updated test
- indents
@aileen aileen mentioned this issue Sep 13, 2017
Merged
aileen added a commit to aileen/amperize that referenced this issue Sep 13, 2017
@aileen
✨ Replace http and https with got
77b5880 
closes jbhannah#99

- Used [`got`](https://github.com/sindresorhus/got) for image-size requests, which is more lightweight and has the huge advantage of following redirects
- Added and updated test
- indents
- Added dependencies:
    - [validator](https://github.com/chriso/validator.js)
    - [lodash](https://github.com/lodash/lodash)
    - [got](https://github.com/sindresorhus/got)
aileen added a commit to aileen/amperize that referenced this issue Sep 13, 2017
@aileen
✨ Replace http and https with got
ebaccdf 
closes jbhannah#99

- Used [`got`](https://github.com/sindresorhus/got) for image-size requests, which is more lightweight and has the huge advantage of following redirects
- Added and updated test
- indents
- Added dependencies:
    - [validator](https://github.com/chriso/validator.js)
    - [lodash](https://github.com/lodash/lodash)
    - [got](https://github.com/sindresorhus/got)
@aileen aileen mentioned this issue Sep 19, 2017
Closed
4 tasks
aileen added a commit to aileen/amperize that referenced this issue Oct 3, 2017
@aileen
✨ Replace http and https with got
71349aa 
closes jbhannah#99

- Used [`got`](https://github.com/sindresorhus/got) for image-size requests, which is more lightweight and has the huge advantage of following redirects
- Added and updated test
- indents
- Added dependencies:
    - [validator](https://github.com/chriso/validator.js)
    - [lodash](https://github.com/lodash/lodash)
    - [got](https://github.com/sindresorhus/got)
aileen added a commit to aileen/amperize that referenced this issue Oct 3, 2017
@aileen
✨ Replace http and https with got
b15df2f 
closes jbhannah#99

- Used [`got`](https://github.com/sindresorhus/got) for image-size requests, which is more lightweight and has the huge advantage of following redirects
- Added and updated test
- indents
- Added dependencies:
    - [validator](https://github.com/chriso/validator.js)
    - [lodash](https://github.com/lodash/lodash)
    - [got](https://github.com/sindresorhus/got)
aileen added a commit to aileen/amperize that referenced this issue Oct 3, 2017
@aileen
✨ Replace http and https with got
f1ea202 
closes jbhannah#99

- Used [`got`](https://github.com/sindresorhus/got) for image-size requests, which is more lightweight and has the huge advantage of following redirects
- Added and updated test
- indents
- dercreased timeout to 3s instead of 5s
- Added dependencies:
    - [validator](https://github.com/chriso/validator.js)
    - [lodash](https://github.com/lodash/lodash)
    - [got](https://github.com/sindresorhus/got)
aileen added a commit to aileen/amperize that referenced this issue Oct 3, 2017
@aileen
✨ Replace http and https with got
c0f10c7 
closes jbhannah#99

- Used [`got`](https://github.com/sindresorhus/got) for image-size requests, which is more lightweight and has the huge advantage of following redirects
- Added and updated test
- indents
- dercreased timeout to 3s instead of 5s
- Added dependencies:
    - [validator](https://github.com/chriso/validator.js)
    - [lodash](https://github.com/lodash/lodash)
    - [got](https://github.com/sindresorhus/got)
kirrg001 pushed a commit that referenced this issue Oct 3, 2017
@aileen @kirrg001
🐛 Fixed following redirects for images (#101)
b37c94a 
closes #99

- Used [`got`](https://github.com/sindresorhus/got) for image-size requests, which is more lightweight and has the huge advantage of following redirects
- Added and updated test
- indents
- decreased timeout to 3s instead of 5s
- Added dependencies:
    - [validator](https://github.com/chriso/validator.js)
    - [lodash](https://github.com/lodash/lodash)
    - [got](https://github.com/sindresorhus/got)
- Removed unused error conditionals
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨ Replace http and https with got aileen/amperize
1 participant
@aileen