-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make backtrace dependency optional #183
Conversation
Fyi I've been working on removing this crate altogether in favour of stabilized/builtin support since Rust 1.65. It was tricky back then because of ownership and clones, but might be more manageable since recent changes: https://github.com/Traverse-Research/gpu-allocator/compare/std-backtrace |
@MarijnS95 Oh that's so cool! Any way I could help? There doesn't seem to be a test nor example for the
|
@MarijnS95 Okay, I took a look at it. From what I can tell, there are two options.
Do you have any preferences? Also, I wish there were a visualizer example. But that's a future request, I suppose. |
No, I'll probably revise and submit it later 😉 |
@MarijnS95 Sounds good. I did make a PR for it, but I'll leave it up to you to figure out the optimal solution :) |
@stefnotch as promised, a PR from that branch is now open at #186. In particular I've addressed the |
On this note, these were unfortunately all removed: #176 In part because we identified a problem way back in the beginning where Vulkan and Dx12 visualizers were basically a massive (verbose, hard to maintain) copy-paste of each-other, rather than going through a cross-compatible interim data-structure saving us all that overhead. Contributions in this area are welcome I think, but let's hear from @tosti007 whether any of this is already in-progress on a branch somewhere. |
I was going through my dependencies, trying to slim down the dependency tree. I saw that
backtrace
depends oncc
, which might be expensive. So I tried to put backtrace inside a feature that can be turned off.The results aren't all that impressive though