Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪛 Replace imgui with egui #176

Merged
merged 7 commits into from
Sep 26, 2023
Merged

🪛 Replace imgui with egui #176

merged 7 commits into from
Sep 26, 2023

Conversation

tosti007
Copy link
Contributor

This PR replaces imgui with egui for the visualizations.

Some notes:

  1. I did try to make the code a bit cleaner along the way, but I think the visualization code can still use some de-duplication.
  2. I removed the examples, as keeping them would mean having to rewrite the renderers to egui as well, we can add these again later is desired.
  3. I kept the functionality as close as possible to the original, but I could not get the "focus" feature to work.
  4. The memory chunk visualization uses the optimized scroll area logic, such that only the visible lines are drawn (this is a must for large blocks, otherwise FPS drops heavily).

image

@tosti007 tosti007 changed the title Replace imgui with egui 🪛 Replace imgui with egui Sep 21, 2023
Copy link
Member

@Jasper-Bekkers Jasper-Bekkers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to see this change, having egui integration for us is significantly more important and imgui was holding us back a bit.

Unfortunate that we're losing some of the samples, but if somebody needs them they're free to port them over to egui.

@tosti007
Copy link
Contributor Author

After request of @Jasper-Bekkers, I also added a screenshot of the visualizers to the README.md

@fu5ha
Copy link
Contributor

fu5ha commented Sep 21, 2023

Nice :D

Copy link
Member

@Jasper-Bekkers Jasper-Bekkers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the readme still needs some work because CI is complaining, but after that we can merge this and make a release

.vscode/settings.json Outdated Show resolved Hide resolved
@tosti007 tosti007 merged commit 79969de into main Sep 26, 2023
@MarijnS95 MarijnS95 deleted the egui_rework branch October 4, 2023 14:39
MarijnS95 added a commit that referenced this pull request Oct 9, 2023
During the `imgui` => `egui` conversion in #176 all window-based
examples were removed but none of their dependencies were removed,
causing a suspiciously-successful `raw-window-handle 0.6` bump by
`dependabot` (#179) despite this being fully incompatible with the
current `winit 0.28` release, as well as `ash-window 0.12`.

Delete `winit`, `ash-window` and `raw-window-handle` from the dependency
table.
MarijnS95 added a commit that referenced this pull request Oct 9, 2023
…182)

During the `imgui` => `egui` conversion in #176 all window-based
examples were removed but none of their dependencies were removed,
causing a suspiciously-successful `raw-window-handle 0.6` bump by
`dependabot` (#179) despite this being fully incompatible with the
current `winit 0.28` release, as well as `ash-window 0.12`.

Delete `winit`, `ash-window` and `raw-window-handle` from the dependency
table.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants