-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🪛 Replace imgui
with egui
#176
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to see this change, having egui integration for us is significantly more important and imgui was holding us back a bit.
Unfortunate that we're losing some of the samples, but if somebody needs them they're free to port them over to egui.
After request of @Jasper-Bekkers, I also added a screenshot of the visualizers to the |
Nice :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the readme still needs some work because CI is complaining, but after that we can merge this and make a release
e4ac15c
to
de8fd51
Compare
de8fd51
to
64b9c49
Compare
During the `imgui` => `egui` conversion in #176 all window-based examples were removed but none of their dependencies were removed, causing a suspiciously-successful `raw-window-handle 0.6` bump by `dependabot` (#179) despite this being fully incompatible with the current `winit 0.28` release, as well as `ash-window 0.12`. Delete `winit`, `ash-window` and `raw-window-handle` from the dependency table.
…182) During the `imgui` => `egui` conversion in #176 all window-based examples were removed but none of their dependencies were removed, causing a suspiciously-successful `raw-window-handle 0.6` bump by `dependabot` (#179) despite this being fully incompatible with the current `winit 0.28` release, as well as `ash-window 0.12`. Delete `winit`, `ash-window` and `raw-window-handle` from the dependency table.
This PR replaces
imgui
withegui
for the visualizations.Some notes:
egui
as well, we can add these again later is desired.